Skip to content
This repository has been archived by the owner. It is now read-only.

Legend shown at openstreetmap.org does not adapt to basemap and is not translatable #1916

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 5 comments

Comments

@openstreetmap-trac
Copy link

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Reporter: ToB
[Submitted to the original trac issue database at 12.45pm, Thursday, 4th June 2009]

Goto [http://www.openstreetmap.org/], click on "Legend" in the middle of left sidebar and you get the following legend shown: [http://www.openstreetmap.org/images/keymapnik15.png]

Expected:

a) If you choose a different base map, the a different legend is shown

b) The language of www.openstreetmap.org matches the language shown in the legend

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: tom[at]compton.nu
[Added to the original trac issue at 2.36pm, Thursday, 4th June 2009]

Please don't put multiple problems on one ticket - it makes the ticket impossible to close.

As far as layers goes, as soon as somebody gives me a key for one of the other layers I can start displaying it. To date only the creators of the mapnik layer have bothered to do this.

As far as translation goes, we are aware that this is an issue but there is no easy solution at the moment as the key is an image.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: avarab[at]gmail.com
[Added to the original trac issue at 12.22pm, Tuesday, 23rd June 2009]

Fixed in changeset [16073] and [16074].

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: tom[at]compton.nu
[Added to the original trac issue at 8.28pm, Tuesday, 23rd June 2009]

Did you do what I repeatedly asked and talk to Jon Burgess and/or Steve8 before making this change?

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: tom[at]compton.nu
[Added to the original trac issue at 8.29pm, Tuesday, 23rd June 2009]

Having just looked at what you committed, it is clearly completely insane so will not be being deployed in it's current state.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: avarab[at]gmail.com
[Added to the original trac issue at 10.15pm, Tuesday, 23rd June 2009]

Replying to [comment:5 tom[at]compton.nu]:

Did you do what I repeatedly asked and talk to Jon Burgess and/or Steve8 before making this change?

I asked Jon Burgess what he thought and he doesn't think he's the best person to offer advice about the style of implementation of features in the railsport.

Having just looked at what you committed, it is clearly completely insane so will not be being deployed in it's current state.

What about it is insane? Dynamically generating HTML with JavaScript? The feature already depends on JS. And the load of serving individual PNG files is negligable as they will be cached on the browser side.

But maybe you have completely different objections. So it would help to get specific objections in the first place and not have to speculate as to what it is that you mean. Mindreading is not one of my many talents.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant