Skip to content
This repository has been archived by the owner. It is now read-only.

Update stylesheet for new power=generator tagging #3266

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 9 comments
Closed

Update stylesheet for new power=generator tagging #3266

openstreetmap-trac opened this issue Jul 23, 2021 · 9 comments

Comments

@openstreetmap-trac
Copy link

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Reporter: tom[at]acrewoods.net
[Submitted to the original trac issue database at 3.31pm, Monday, 4th October 2010]

The tags combined with power=generator have recently been revised following a proposal I wrote. The tags 'power_source' and 'power_rating' have been deprecated. See the new schema here:

http://wiki.openstreetmap.org/wiki/Tag:power%3Dgenerator

The stylesheet needs to change from this:

<Rule>
  <MaxScaleDenominator>20000</MaxScaleDenominator>
  <Filter>[man_made]='power_wind' or ([power]='generator' and [power_source] = 'wind')</Filter>
  <PointSymbolizer file =  "%SYMBOLS_DIR%/power_wind.png" type="png" width="16" height="26" />
</Rule>

To this:

<Rule>
  <MaxScaleDenominator>20000</MaxScaleDenominator>
  <Filter>[man_made]='power_wind' or ([power]='generator' and [power_source] = 'wind') or ([power]='generator' and [generator:source] = 'wind')</Filter>
  <PointSymbolizer file =  "%SYMBOLS_DIR%/power_wind.png" type="png" width="16" height="26" />
</Rule>
@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: Schusch
[Added to the original trac issue at 1.01am, Thursday, 25th November 2010]

as far as I see it, it is done here:

http://trac.openstreetmap.org/changeset/23651

but it still doesn't work - I changed the wind turbine tagging in this area:

http://www.informationfreeway.org/?lat=52.17521032657653&lon=11.461634062973785&zoom=16&layers=0FB0F0

(no wind turbines anymore now to see in mapnik rendering)

but didn't touch it in this area:

http://www.informationfreeway.org/?lat=52.174012851447&lon=11.5535372527544&zoom=16&layers=0FB0F0

(wind turbines are still there)

It would be really nice to add the support for the new power mapping scheme (http://wiki.openstreetmap.org/wiki/Key:generator:source) in mapnik

And by the way - thanks for your good work up to now :-)

Greetings, Schusch

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: tom[at]acrewoods.net
[Added to the original trac issue at 9.13am, Thursday, 25th November 2010]

I've no idea when those mapnik changes will be reflected in the rendering, but you might want to leave the old tags intact whilst adding the new ones to assist people whose tools don't have the new schema yet.

For example, there's no need to delete 'power_source=wind' when adding 'generator:source=wind'.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: Ldp
[Added to the original trac issue at 9.19am, Thursday, 25th November 2010]

This particular change will not be rendered anytime soon, as it was reverted right away: http://trac.openstreetmap.org/changeset/23652

The reason is that we do not have every tag available in mapnik's current database, and generator:source is one of those we do not have yet.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: tom[at]acrewoods.net
[Added to the original trac issue at 9.36am, Thursday, 25th November 2010]

Thanks for the update, do you know when you will have it?

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: Schusch
[Added to the original trac issue at 3.22pm, Saturday, 15th January 2011]

I sended Steve an email - he reverted the change, writing it is an error - perhaps he didn't see the new tagging scheme?

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: Ldp
[Added to the original trac issue at 10.25pm, Wednesday, 23rd March 2011]

The reason for the revert was that we don't have generator:source in the rendering db yet.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: don-vip
[Added to the original trac issue at 8.02pm, Wednesday, 13th July 2011]

Is there a way to see ourselves when the tag is in the rendering db ?

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: Schusch
[Added to the original trac issue at 4.34pm, Wednesday, 2nd November 2011]

any chance for a change more than a year for the new tagging scheme? most of the keys now have the old and the new tags because only the old ones are rendered ...

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: Ldp
[Added to the original trac issue at 6.47pm, Wednesday, 22nd February 2012]

Added in r27809

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant