Adding an amenity tag removed building=yes

[openstreetmap-trac]

Reporter: Zverik
[Submitted to the original trac issue database at 5.30am, Saturday, 24th September 2011]

When you select a building in Potlatch 2 and attempt to mark that a school (a post office, a cafe) is in it, the building tag gets erased. It seems like Potlatch does not support buildings that are also something else. Several users have complained that novices removed a lot of building tags that way. There should be support for adding amenity (and other) tags on buildings - or a big warning about that.

[openstreetmap-trac]

Author: Zverik
[Added to the original trac issue at 12.36pm, Monday, 7th November 2011]

I've dug into presets, and the source of this problem is that when the feature type for selected object is changed, tags for old feature are removed, and new ones are added. building=* somehow should not be removed when the target preset uses inputSet "isBuilding".

[openstreetmap-trac]

Author: Zverik
[Added to the original trac issue at 1.06pm, Monday, 7th November 2011]

Probably, tags that have inputs in the target preset should not be removed. I guess it isn't hard to implement.

[openstreetmap-trac]

Author: Zverik
[Added to the original trac issue at 1.46pm, Monday, 7th November 2011]

Zverik/potlatch2@4df75aa should probably solve this