Skip to content
This repository has been archived by the owner. It is now read-only.

Adding OpenID URL makes log in impossible #4165

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments
Closed

Adding OpenID URL makes log in impossible #4165

openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments

Comments

@openstreetmap-trac
Copy link

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Reporter: emj
[Submitted to the original trac issue database at 10.06pm, Tuesday, 27th December 2011]

  1. create a new user[[BR]]
  2. add an openid url[[BR]]
  3. save[[BR]]

Result:

You are logged out and logging in with password doesn't work. I tested this with the user fake_123 and password fake_123.

See:

http://help.openstreetmap.org/questions/9623/how-can-i-log-in-to-openstreetmaporg

http://help.openstreetmap.org/questions/9631/cant-log-in

Note I could do more work on this report, but I need sleep.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: emj
[Added to the original trac issue at 9.01am, Thursday, 29th December 2011]

More problems, and a fix

  1. add a openid url to an account
  2. you get logged out

result:
Login will not work, for any account.

Fix: removing cookies for openstreetmap.org will help.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: amm
[Added to the original trac issue at 6.22pm, Friday, 10th February 2012]

This is a very odd bug. It appears to sometimes work and sometimes doesn't. With the same code, the bug is sometimes reproducable on a test instance while it works on osm.org and vice versa.

From what I have been able to track down, the problem appears to be originating outside of our code and somewhere in the middleware of rails. The session db gets corrupted and looses the relevant information during the OpenID redirect, resulting in the logged out user. Given the intermittent nature of the issue, my guess would be some form of race condition, but I haven't been able to debug this any further as I don't know how to debug the session store middleware.

When I tried this a couple of weeks ago on osm.org, adding a OpenID, however, worked correctly again. Do others still see this problem? Did it recently start again?

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: TomH
[Added to the original trac issue at 7.13pm, Monday, 26th November 2012]

I suspect this was caused by openid state data not being shared properly across all the machines, which was fixed by this commit:

http://git.openstreetmap.org/rails.git/commit/f89dda9b906706da007e8185e8ffcd8a65ebac36

Is anybody still seeing this problem now?

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: TomH
[Added to the original trac issue at 11.59am, Monday, 9th September 2013]

We haven't had any more complaints so I assume I was right about this now being fixed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant