Skip to content
This repository has been archived by the owner. It is now read-only.

RSS auto discovery link missing from diary entry lists #4670

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 8 comments
Closed

RSS auto discovery link missing from diary entry lists #4670

openstreetmap-trac opened this issue Jul 23, 2021 · 8 comments

Comments

@openstreetmap-trac
Copy link

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Reporter: Zverik
[Submitted to the original trac issue database at 1.18pm, Tuesday, 6th November 2012]

All those pages have no link to their RSS feeds. But they had some time ago. Probably a regression, and needs to be fixed.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: TomH
[Added to the original trac issue at 10.36am, Wednesday, 7th November 2012]

They all seem to have RSS links when I look at them.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: smsm1
[Added to the original trac issue at 10.39am, Wednesday, 7th November 2012]

It's the orange RSS icon at the bottom of the page on all three of those pages.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: Zverik
[Added to the original trac issue at 10.49am, Wednesday, 7th November 2012]

Ok, I agree that there are RSS links at the bottom. But all RSS readers and browsers expect them to be in meta tag:

<link rel="alternate" type="application/rss+xml" title="RSS" href="http://openstreetmap.org/diary/rss" />

So I propose to add this tag where relevant.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: TomH
[Added to the original trac issue at 10.59am, Wednesday, 7th November 2012]

We do add it - that's what the auto_discovery_link_tag line in app/views/diary_entry/list.html.erb does.

I think it's being defeated by the caching on the page though, and there's no real way to fix that without reworking the caching completely. It works on my dev instance where there is no caching.

Firefox at least long since stopped paying any attention to those tags anyway.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: Zverik
[Added to the original trac issue at 11.10am, Wednesday, 7th November 2012]

I've checked http://www.openstreetmap.org/diary/fr which I've never visited in my life, and there is no RSS auto discovery link. Should it appear after anyone adds another diary entry, or the caching is more complicated than that?

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: TomH
[Added to the original trac issue at 11.26am, Wednesday, 7th November 2012]

No the point is that if the page is cached (this is a server side cache) then the view is never run and hence the content_for block doesn't stash the content so when :head is rendered the auto_discovery_link_tag is not there.

Basically the cache only stores the actual content of the page and not the side effects like content_for blocks.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: Zverik
[Added to the original trac issue at 11.37am, Wednesday, 7th November 2012]

Is it possible to clear relevant caches when restarting the server, if this would come up anytime soon? Right now it seems like we cannot modify website's pages at all because of caching. Not that it is needed often.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: TomH
[Added to the original trac issue at 2.52pm, Saturday, 30th November 2013]

The caching of this page was removed some time ago, which fixed this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant