Skip to content
This repository has been archived by the owner. It is now read-only.

Rhine relation (and possibly other rivers too) not included in the database (and not found in search on osm.org) #4883

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 7 comments

Comments

@openstreetmap-trac
Copy link

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Reporter: aseerel4c26
[Submitted to the original trac issue database at 5.35pm, Sunday, 23rd June 2013]

(related to https://help.openstreetmap.org/questions/23189/bachlauf-richtig-erfassen-relation )

Why is the relation for river Rhine http://www.openstreetmap.org/browse/relation/123924 not known to Nominatim http://nominatim.openstreetmap.org/details?osmtype=R&osmid=123924 ? If one searches on osm.org for "Rhein" a result for the whole river would be far more useful than only single riverbank closed ways.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: bdiscoe
[Added to the original trac issue at 7.06pm, Friday, 4th April 2014]

This is major. I just did a great deal of work to make a single relation for "Klamath River", only to discover that OSM site's search of "Klamath River" fails to find it. This is really bad. Rivers should be very easy to support.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: lonvia
[Added to the original trac issue at 7.18pm, Friday, 4th April 2014]

As always: patches/pull requests are welcome.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: lonvia
[Added to the original trac issue at 7.25pm, Monday, 21st April 2014]

See also osm-search/Nominatim#130

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: lonvia
[Added to the original trac issue at 10.26pm, Monday, 5th May 2014]

Support for waterway relations added in [https://github.com/openstreetmap/osm2pgsql/commit/e1aa1badba5c03962fbeb59fcc34c9d67bf57b69 osm2pgsql]. However it works properly only for rivers that have exactly one linear stream. If there are breaks or side arms, a random linear section will be returned as geometry. Same fix needed as for sectioned roads.

Also need to figure out how to improve search results so that the river ways show up further down in the list (or not at all).

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: lonvia
[Added to the original trac issue at 9.30pm, Wednesday, 7th May 2014]

Containing waterway ways are now excluded as of [changeset:052d219/nominatim], which should resolve this issue in terms of searching for waterway relations. Note that the DB on osm.org will still take a while to sort itself out. Search results still contain lots of waterway=riverbank ways. Those have been excluded from indexing now and should disappear gradually.

Geometry issue remains to be solved. Moved this to [https://github.com/osm-search/Nominatim/issues/133 a separate issue].

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: bdiscoe
[Added to the original trac issue at 9.20pm, Wednesday, 11th June 2014]

This defect still exists today. For example, from the search box on www.openstreetmap.org:

Doing a nominatim search on "Rhine" does not return the Rhine relation (http://www.openstreetmap.org/relation/123924) in its results anywhere.

Doing a nominatim search on "Klamath River" does not return the Klamath River relation (http://www.openstreetmap.org/relation/3624126) in its results anywhere.

The Klamath has no "breaks or side arms", so that is not the problem. The search simply does not find it.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: lonvia
[Added to the original trac issue at 10.07pm, Wednesday, 11th June 2014]

As stated in the final comment: the DB has not been reimported. So relations only become searchable at the moment when the relations are edited. There is a complete reimport planned in the near future which will make sure that all waterways are shown correctly. So please be patient until then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant