Skip to content
This repository has been archived by the owner. It is now read-only.

"Share/HTML" unexpectedly leaves away some highlight features #4948

Open
openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments
Open

"Share/HTML" unexpectedly leaves away some highlight features #4948

openstreetmap-trac opened this issue Jul 23, 2021 · 4 comments

Comments

@openstreetmap-trac
Copy link

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Reporter: aseerel4c26
[Submitted to the original trac issue database at 8.54pm, Tuesday, 13th August 2013]

Highlights (&relation, , &box) included in the current map view on osm.org will not be shown on the embedded map.

Example: http://www.openstreetmap.org/?box=yes&bbox=10.18%2C50.24%2C10.24%2C50.26&relation=23419 Now go to Share menu and select HTML. Look at the produced code.

"Share/HTML" leaves away those features. It would be nice if they either
*were also included in the code and shown on the embedded map OR
*if the user of the "Share/HTML" feature would be informed that those features are missing. For example by changing the currently shown info text "Paste HTML to embed in website" to: Paste HTML to embed in website. Note that only the current map dimensions and the layer selection will be transferred to the produced HTML code

Background: Confused users - see comment " but the embedded map doesn't have the relation shown at all " at https://help.openstreetmap.org/questions/420/

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: TomH
[Added to the original trac issue at 11.45am, Wednesday, 14th August 2013]

I'm right in thinking this has always been the case? It's not a regression with the move to the new sharing panel?

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: aseerel4c26
[Added to the original trac issue at 11.59am, Wednesday, 14th August 2013]

@TomH: yes, that could be.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: TomH
[Added to the original trac issue at 12.03pm, Wednesday, 14th August 2013]

I'm not at all sure we want to allow this to be honest - it's potentially very dangerous from a load perspective if somebody uses it to stick a map somewhere that has a large and complex relation on it.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: aseerel4c26
[Added to the original trac issue at 12.37pm, Wednesday, 14th August 2013]

You mean accidental DDoS of osm.org? hmm...

What about changing the text for now? It is only shown if somebody really clicks on "HTML" - so it is not cluttering the sidebar (I guess showing the text only if the current URL contains a not supported feature parameter is too much overhead). Or want we want to just forget that use case for simplicity?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant