Skip to content
This repository has been archived by the owner. It is now read-only.

ctrl click does not work in user changeset list #5044

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 7 comments
Closed

ctrl click does not work in user changeset list #5044

openstreetmap-trac opened this issue Jul 23, 2021 · 7 comments

Comments

@openstreetmap-trac
Copy link

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Reporter: aseerel4c26
[Submitted to the original trac issue database at 4.53pm, Friday, 29th November 2013]

ctrl click (for new tab) is prevented (and instead loaded in the small sidebar) for the changeset links in http://www.openstreetmap.org/user/aseerel4c26/history

stop messing around with my user interface

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: TomH
[Added to the original trac issue at 4.44pm, Saturday, 30th November 2013]

I can make this work, but only by suppressing the inline load when ctrl is held down, and it's not at clear that it is correct to do that on all browsers... It is only really correct on those browsers where ctrl is defined to cause a load in a new window.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: aseerel4c26
[Added to the original trac issue at 5.06pm, Saturday, 30th November 2013]

Thanks Tom, not tested of course.

However, you can imagine what that means for the current design. ;-) A mix of real links and fake links (even showing a URL as target - good side: at least allowing middle click to open a new tab).

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: TomH
[Added to the original trac issue at 12.32am, Tuesday, 3rd December 2013]

Fixed by openstreetmap/openstreetmap-website#599.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: aseerel4c26
[Added to the original trac issue at 5.27pm, Tuesday, 3rd December 2013]

Thanks Tom! Ctrl and Shift as modifier (and Firefox) work again as expected.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: dieterdreist
[Added to the original trac issue at 10.32pm, Sunday, 8th December 2013]

It is not completely working. It does work when you click on the changeset description but it doesn't on the changeset-number (while a single left click on the number gets you to the changeset). I was used to click on the changeset number and thought this didn't work at all, until I found this ticket and found out that the changeset-description link worked.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: TomH
[Added to the original trac issue at 10.54pm, Sunday, 8th December 2013]

This is a browser limitation - some browsers (at least Firefox, maybe others) do not generate click events for things which are not links if you are holding a modifier key. So it's out of our control really, at least unless we make that an actual link, but that still wouldn't help with the rest of the clickable area.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: osm[at]gravitystorm.co.uk
[Added to the original trac issue at 12.44pm, Wednesday, 28th August 2019]

If this is still a problem, please open a fresh issue at https://github.com/openstreetmap/openstreetmap-website

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant