Skip to content
This repository has been archived by the owner. It is now read-only.

(only) imprecise timestamps in the user changesets and on object history pages are not useful #5045

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 11 comments

Comments

@openstreetmap-trac
Copy link

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Reporter: aseerel4c26
[Submitted to the original trac issue database at 4.12pm, Saturday, 30th November 2013]

http://www.openstreetmap.org/user/aseerel4c26/history

Just because one CAN display such vague times there is no MUST to do it, right?

Lost functionality: I cannot use in-page search to find an edit from a specific day.

I do not understand why the interface needs to be changed every two months. We want mappers working on our data not testing how good they are in learning new interfaces, right?

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: TomH
[Added to the original trac issue at 4.45pm, Saturday, 30th November 2013]

Hover over a time and it will show the precise value in a tooltip.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: aseerel4c26
[Added to the original trac issue at 5.07pm, Saturday, 30th November 2013]

Sure, the attention catching dotted underline and the on hover mouse pointer makes that clear. Still the concerns are not addressed.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: TomH
[Added to the original trac issue at 5.22pm, Saturday, 30th November 2013]

The point is that design is always a trade off - we can't always do everything that everybody wants if for no other reason that different people may have conflicting views.

We have chosen to show a concise and user friendly rough date and give those people who really need to see the full time a way to do so. Yes it may break some odd edge cases like searching for a date, but I really find it hard to believe that is a common thing for people to do.

I don't see that there is any way to make the search work other than going back to showing full dates, hence regrettably I don't think we will be able to fix this.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: aseerel4c26
[Added to the original trac issue at 9.14pm, Thursday, 5th December 2013]

Many times "vor etwa 5 Jahre" at http://www.openstreetmap.org/node/123456/history

How to see the timespans between the single edits? Was it rather like one day or several months inbetween? Hard with the current setup. Where is the workaround or, better, the user setting?!

I was fiddling (about an hour in total yes, I also could have been mapping!) with it (already some days ago) ... but was stuck at

  alert("fire");
  if (document.location.href.split('#')[0].split('/').length > 4) {
    $( document ).ready(function() {
	 alert("run");
	 $("div#sidebar_content div.details abbr").each(function() {
	 $( this ).replaceWith("(" + $( this ).attr("title") + " [" + $( this ).html() + "])");
	 });
    });
  }

Inserted via NoScript's script surrogates this did not'' work. And will not since these surrogates are executed after page load ''once. But the new object histories are loaded without a full page load. If I run it manually via Firefox' JavaScript console it works as intended. Maybe it is possible to run this path via GreaseMonkey or something but I am not really willing to install another addon just for fixing the openstreetmap page ... Maybe someone has another idea or - well, make that time display thing at least (!) a user setting.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: aseerel4c26
[Added to the original trac issue at 9.45pm, Thursday, 5th December 2013]

the resolution was set to "fixed"? No, it is not fixed, really not. At best it is "wontfix". However, I hope that someone else may be willing to provide a fix. That does not need to be you, Tom.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: TomH
[Added to the original trac issue at 9.48pm, Thursday, 5th December 2013]

I'm sorry, who exactly gave you the power to decide who can and can't provide a fix?

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: aseerel4c26
[Added to the original trac issue at 9.49pm, Thursday, 5th December 2013]

Replying to [comment:7 TomH]:

I'm sorry, who exactly gave you the power to decide who can and can't provide a fix?

sorry, I confused "must not" and "need not" (it is the other way round in German ). Fixed in the above comment.

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: aseerel4c26
[Added to the original trac issue at 11.49pm, Thursday, 5th December 2013]

Those about:config entries ([http://hackademix.net/2011/09/29/script-surrogates-quick-reference/ for NoScript]) work at least for nearly* all pages (if not loaded via JavaScript navigation). You may be able to use these snippets also for other tools (e.g. GreaseMonkey or browser user profile-specific .js files).

  • noscript.surrogate.osmorg.sources: !@www.openstreetmap.org/
  • noscript.surrogate.osmorg.replacement:

This expands the "abbr" tag (containing the relative timestamps):

if (document.location.href.split('#')[0].split('/').length > 4) {
  $("div#sidebar_content div.details abbr").each(function() {
  $( this ).replaceWith("(" + $( this ).attr("title") + " [" + $( this ).html() + "])");
  });
}

To remove the imprecise time interpretation completely just (but keeping the JS syntax correct) the the [] part. E.g. this:

if (document.location.href.split('#')[0].split('/').length > 4) {
  $("div#sidebar_content div.details abbr").each(function() {
  $( this ).replaceWith("(" + $( this ).attr("title") + ")");
  });
}

Or even have an (unordered) list for the timestamps (biggest visual effect in case of [http://www.openstreetmap.org/changeset/19281117 changeset pages]). Includes an ugly CSS line to overwrite the globally disabled bullets for li objects (list elements) I see no reason why this is done anyway (makes the lists not easy to read in case of line wraps)

if (document.location.href.split('#')[0].split('/').length > 4) {
  $("div#sidebar_content div.details abbr").each(function() {
    $( this ).replaceWith("<ul><li>" + $( this ).attr("title").replace("\n","</li>\n<li>") + "</li></ul>");
  });
  $("div#sidebar_content li").css("list-style-type","disc");
}

* except for [http://www.openstreetmap.org/user/aseerel4c26/history user changeset lists] which contain no content (the content gets loaded via JavaScript after the page has been loaded in the browser).

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: woodpeck
[Added to the original trac issue at 1.04am, Friday, 6th December 2013]

Thank you for providing this. See also openstreetmap/openstreetmap-website#631

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: aseerel4c26
[Added to the original trac issue at 1.40pm, Friday, 6th December 2013]

Replying to [comment:10 woodpeck]:
I made some tweaks (readability, grammar) and improved last code snippet (bullets for lists).

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: osm[at]gravitystorm.co.uk
[Added to the original trac issue at 12.47pm, Wednesday, 28th August 2019]

Closing here in favour of openstreetmap/openstreetmap-website#631

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant