Skip to content
This repository has been archived by the owner. It is now read-only.

Duplicate HTML ID on login page #5211

Closed
openstreetmap-trac opened this issue Jul 23, 2021 · 1 comment
Closed

Duplicate HTML ID on login page #5211

openstreetmap-trac opened this issue Jul 23, 2021 · 1 comment

Comments

@openstreetmap-trac
Copy link

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Reporter: Rudloff
[Submitted to the original trac issue database at 6.16pm, Saturday, 9th August 2014]

On the login page, the remember_me_openid ID exists twice:

<div class="form-row" id="remember_me_openid">
            <input type="checkbox" value="yes" tabindex="5" name="remember_me_openid" id="remember_me_openid">
            <label for="remember_me_openid" class="standard-label">Se souvenir de moi</label>
          </div>

This is not valid HTML and due to this a click on the label does not check the associated checkbox (at least on Firefox).

@openstreetmap-trac
Copy link
Author

@openstreetmap-trac openstreetmap-trac commented Jul 23, 2021

Author: xnyhps
[Added to the original trac issue at 10.58am, Sunday, 1st February 2015]

This was fixed in [https://github.com/openstreetmap/openstreetmap-website/commit/17f926fefb1329aaa41a64634d17d1dffd3ddba5 17f926fefb1329aaa41a64634d17d1dffd3ddba5].

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant