Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] statusbar pophover 支持 icon 展示 #1977

Closed
hacke2 opened this issue Nov 16, 2022 · 3 comments · Fixed by #2340
Closed

[BUG] statusbar pophover 支持 icon 展示 #1977

hacke2 opened this issue Nov 16, 2022 · 3 comments · Fixed by #2340
Assignees
Labels
🐞 bug Something isn't working

Comments

@hacke2
Copy link
Member

hacke2 commented Nov 16, 2022

描述你的问题(Describe the bug)

image

复现路径(To Reproduce)

预期表现(Expected behavior)

问题截图(Screenshots)

环境信息(Environment)

  • OS: [e.g. macOS 11.2 Apple M1/Windows10/Windows11]
  • Browser: [e.g. chrome, safari, electron]
  • OpenSumi Version: [e.g. 2.13.0]

补充信息(Additional context)

@hacke2 hacke2 added the 🐞 bug Something isn't working label Nov 16, 2022
@hacke2 hacke2 self-assigned this Nov 16, 2022
@erha19
Copy link
Member

erha19 commented Nov 16, 2022

https://github.com/opensumi/core/blob/fbb5ce9e7613898255a8ba82dc730b6fe5890ec4/packages/core-browser/src/utils/label.tsx 可以统一用这个方法,不过目前缺少对 ~spin 动态图标的支持

@erha19
Copy link
Member

erha19 commented Jan 29, 2023

image

类型问题

@bytemain
Copy link
Member

export function parseLabel(text: string): LabelPart[] {

这个文件里的方法支持:

  • $(kticon/sync~spin)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants