Skip to content

Conversation

@erha19
Copy link
Member

@erha19 erha19 commented Nov 2, 2022

Types

  • 🐛 Bug Fixes

Background or solution

close #1898.
close #1312.

After:

image

Changelog

  • always highlight search results

@github-actions github-actions bot added the 🐞 bug Something isn't working label Nov 2, 2022
@bytemain
Copy link
Member

bytemain commented Nov 2, 2022

this close: #1312

@bytemain
Copy link
Member

bytemain commented Nov 2, 2022

fantastic!

@erha19 erha19 linked an issue Nov 2, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 57.67% // Head: 57.66% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (878843d) compared to base (1d825f1).
Patch coverage: 9.09% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##            v2.21    #1900      +/-   ##
==========================================
- Coverage   57.67%   57.66%   -0.02%     
==========================================
  Files        1284     1284              
  Lines       80403    80397       -6     
  Branches    16826    16824       -2     
==========================================
- Hits        46376    46363      -13     
- Misses      30952    30957       +5     
- Partials     3075     3077       +2     
Flag Coverage Δ
jsdom 52.42% <9.09%> (-0.02%) ⬇️
node 15.89% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/search/src/browser/search-tree.service.ts 35.94% <9.09%> (+0.37%) ⬆️
packages/utils/src/buffer.ts 30.81% <0.00%> (-6.98%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 25b9e3e into v2.21 Nov 2, 2022
@erha19 erha19 deleted the fix/hightlight-search-results branch November 2, 2022 09:44
yantze pushed a commit that referenced this pull request Nov 9, 2022
* fix: always highlight search results

* chore: fix build error
# Conflicts:
#	packages/search/src/browser/search-tree.service.ts
@erha19 erha19 mentioned this pull request Nov 14, 2022
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] 文件搜索高亮与编辑器高亮存在差异

3 participants