Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: server's incorrect dispose of service center #3794

Closed
wants to merge 6 commits into from

Conversation

opensumi[bot]
Copy link
Contributor

@opensumi opensumi bot commented Jun 21, 2024

Types

  • 🐛 Bug Fixes

Background or solution

又梳理了一下重连会带来的一些问题

  1. rpc service center 和 channel 的 dispose 没有完全清理干净
  2. 新建 channel 没有删掉旧的, 旧 channel 仍然可以收到消息
  3. 重连会多次创建 Worker,导致通信很多报错
  4. EventQueue 逻辑有问题,当没有接收方的时候,没有存消息到队列中

Changelog

fix server's incorrect dispose of service center


Backport from #3785 a7a69f6

Thanks to @bytemain for your valuable contribution.

@opensumi opensumi bot added 🚧 backport 🐞 bug Something isn't working labels Jun 21, 2024
@bytemain bytemain closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚧 backport 🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant