From 9ec15430d35f7677b47aa8a7ab4f68f6e48c26ba Mon Sep 17 00:00:00 2001
From: Justin Walgran <jwalgran@azavea.com>
Date: Wed, 3 Jul 2019 17:14:33 -0700
Subject: [PATCH] Add changed values to facility update emails

When notifying contributors when facility claimants change the profile of a
facility we want to include the specific public details that were changed.

The non-standard position of the `endfor` in the plain text email template is
intentional and ensures that extra blank lines are not included.
---
 src/django/api/mail.py                                    | 8 ++++++++
 ...lity_claim_profile_update_contributor_notice_body.html | 8 ++++++++
 ...ility_claim_profile_update_contributor_notice_body.txt | 7 +++++++
 3 files changed, 23 insertions(+)

diff --git a/src/django/api/mail.py b/src/django/api/mail.py
index f1e31c7a6..9935c411e 100644
--- a/src/django/api/mail.py
+++ b/src/django/api/mail.py
@@ -172,11 +172,19 @@ def send_claim_update_note_to_one_contributor(request, claim, contributor):
 
     facility_country = COUNTRY_NAMES[claim.facility.country_code]
 
+    changes = claim.get_changes()
+    if changes:
+        changes = [
+            '{}: {}'.format(c['verbose_name'], c['current'])
+            for c in changes
+        ]
+
     notice_dictionary = {
         'facility_name': claim.facility.name,
         'facility_address': claim.facility.address,
         'facility_country': facility_country,
         'facility_url': make_facility_url(request, claim.facility),
+        'changes': changes,
     }
 
     send_mail(
diff --git a/src/django/api/templates/mail/facility_claim_profile_update_contributor_notice_body.html b/src/django/api/templates/mail/facility_claim_profile_update_contributor_notice_body.html
index 0134fbbc6..d84d53e03 100644
--- a/src/django/api/templates/mail/facility_claim_profile_update_contributor_notice_body.html
+++ b/src/django/api/templates/mail/facility_claim_profile_update_contributor_notice_body.html
@@ -25,6 +25,14 @@
                 Facility URL: {{ facility_url }}
             </li>
         </ul>
+        {% if changes %}
+        <p>The following details have been changed:</p>
+        <ul>
+            {% for change in changes %}
+            <li>{{ change }}</li>
+            {% endfor %}
+        </ul>
+        {% endif %}
         <p>
             Sincerely,
         </p>
diff --git a/src/django/api/templates/mail/facility_claim_profile_update_contributor_notice_body.txt b/src/django/api/templates/mail/facility_claim_profile_update_contributor_notice_body.txt
index e63d35a95..fa0eb7064 100644
--- a/src/django/api/templates/mail/facility_claim_profile_update_contributor_notice_body.txt
+++ b/src/django/api/templates/mail/facility_claim_profile_update_contributor_notice_body.txt
@@ -9,6 +9,13 @@ The facility is:
   - Facility: {{ facility_name }}, {{ facility_address }}, {{ facility_country }}
   - Facility URL: {{ facility_url }}
 
+{% if changes %}
+The following details have been changed:
+
+  {% for change in changes %}
+  - {{ change }} {% endfor %}
+{% endif %}
+
 Sincerely,
 {% include "mail/signature_block.txt" %}
 {% endblock content %}