Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Articles should also be optionally 'private' #331

Closed
nickbe opened this Issue Oct 9, 2018 · 4 comments

Comments

3 participants
@nickbe
Copy link

nickbe commented Oct 9, 2018

It should be possible to differ between 'public' articles and 'internal' articles.
A simple switch 'internal only' would do when creating an article.

@ivandiazwm ivandiazwm added this to Ready for dev in Features Oct 15, 2018

@guillegiu

This comment has been minimized.

Copy link
Collaborator

guillegiu commented Oct 23, 2018

Hi Nick, I'm working on this feature and I think it would be better if we create "Private topic" with its own private articles instead directly create "private articles". I think it will be more consistent in this way because it can be confusing to have private and public articles mixed. Tell me if you agree.

@nickbe

This comment has been minimized.

Copy link
Author

nickbe commented Oct 24, 2018

This is the logical solution of course and you're perfectly right there.
I think this what I actually had in mind too 😄

@nickbe

This comment has been minimized.

Copy link
Author

nickbe commented Oct 24, 2018

Can you let us choose the departments for which topics are valid (privates only)?

Depending on the staffs department this would also make sense regarding who may care about which topics.

@guillegiu guillegiu moved this from Ready for dev to In progress in Features Oct 30, 2018

guillegiu added a commit to guillegiu/opensupports that referenced this issue Nov 8, 2018

@guillegiu guillegiu moved this from In progress to Code Review in Features Nov 9, 2018

guillegiu added a commit to guillegiu/opensupports that referenced this issue Nov 16, 2018

@ivandiazwm ivandiazwm moved this from Code Review to Merged in Features Nov 29, 2018

@ivandiazwm

This comment has been minimized.

Copy link
Contributor

ivandiazwm commented Nov 29, 2018

This feature has been released

@ivandiazwm ivandiazwm closed this Nov 29, 2018

@ivandiazwm ivandiazwm moved this from Merged to Released in Features Nov 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.