Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't compress man pages #24

Closed
wants to merge 1 commit into from
Closed

build: don't compress man pages #24

wants to merge 1 commit into from

Conversation

thesamesam
Copy link
Contributor

This tends to complicate packaging for downstreams as we may choose to
not compress man pages at all, use a different tool, or use different
options.

Most projects don't therefore bother compressing, so this change
brings multipath-tool in line with others.

Signed-off-by: Sam James sam@gentoo.org

@mwilck
Copy link
Contributor

mwilck commented Jan 3, 2022

With this patch, make clean deletes the libdmmp manpages (libdmmp/docs/man/). Please fix that.

In general, please submit to the dm-devel mailing list, adding at least mwilck at suse dot com and bmarzins at redhat dot com to CC.

This tends to complicate packaging for downstreams as we may choose to
not compress man pages at all, use a different tool, or use different
options.

Most projects don't therefore bother compressing, so this change
brings multipath-tool in line with others.

Signed-off-by: Sam James <sam@gentoo.org>
@thesamesam
Copy link
Contributor Author

Sorry for the oversight, good catch. I'll send the patch there now.

Copy link
Contributor

@mwilck mwilck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

@mwilck
Copy link
Contributor

mwilck commented Jan 3, 2022

@cvaroqui cvaroqui closed this Feb 18, 2022
@thesamesam thesamesam deleted the no-compress-man branch February 18, 2022 10:35
@mwilck mwilck mentioned this pull request Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants