Add missing include <assert.h> #25
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Patches should be posted to dm-devel list, see README. |
|
Well this is simple enough to be merged without going through the mailing list, I suppose. But we still won't be using a PR workflow. @Uglymotha, please add a Signed-off-by line. |
|
When the s-o-b is added, I'll push this to https://github.com/openSUSE/multipath-tools/tree/queue and include it into the next PR here. (on those systems where I was testing, |
|
@Uglymotha, our policy is to add an s-o-b to every commit. If you can't provide an updated patch, I'll recreate your patch with my s-o-b, giving you credit with a |
checkers.c: In function 'start_checker_thread':
checkers.c:392:9: error: implicit declaration of function 'assert' [-Werror=implicit-function-declaration]
392 | assert(ctx && ctx->cls && ctx->cls->thread);
| ^~~~~~
checkers.c:13:1: note: 'assert' is defined in header '<assert.h>'; did you forget to '#include <assert.h>'?
Signed-off-by: Sietse van Zanen <uglymotha@wizdom.nu>
|
Hi,
Apologies for the late reaction, I was on vacation last week. Commit message has been amended with signed-off-by.
…-Sietse
From: Martin Wilck ***@***.***>
Sent: Thursday, 17 February 2022 17:46
To: opensvc/multipath-tools ***@***.***>
Cc: Sietse van Zanen ***@***.***>; Mention ***@***.***>
Subject: Re: [opensvc/multipath-tools] Add missing include <assert.h> (PR #25)
@Uglymotha<https://github.com/Uglymotha>, our policy is to add an s-o-b to every commit. If you can't provide an updated patch, I'll recreate your patch with my s-o-b, giving you credit with a Reported-by: tag. Anyway, I'll wait a few more days.
—
Reply to this email directly, view it on GitHub<#25 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC3S6AMMLVNXDVTMHOJ7KKLU3UQ4BANCNFSM5LQJMREA>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkers.c: In function 'start_checker_thread':
checkers.c:392:9: error: implicit declaration of function 'assert' [-Werror=implicit-function-declaration]
392 | assert(ctx && ctx->cls && ctx->cls->thread);
| ^~~~~~
checkers.c:13:1: note: 'assert' is defined in header '<assert.h>'; did you forget to '#include <assert.h>'?