Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reactome.py to URLZSource #371

Closed
afaulconbridge opened this issue Dec 11, 2018 · 3 comments

Comments

Projects
None yet
1 participant
@afaulconbridge
Copy link

commented Dec 11, 2018

reactome.py uses Requests directly. We should update it to use the URLZSource() function to wrap the download with a local file for consistency.

@afaulconbridge

This comment has been minimized.

Copy link
Author

commented Dec 11, 2018

Partially related to #327

@afaulconbridge

This comment has been minimized.

Copy link
Author

commented Dec 12, 2018

We should also update Reactome.py to use flush_all_and_wait() on the loader to ensure the index is ready when the process is complete.

@afaulconbridge

This comment has been minimized.

Copy link
Author

commented Dec 12, 2018

Branch af-371-reactome-updates on data_pipeline created.

@afaulconbridge afaulconbridge changed the title Update Reactome.py to URLZSource Update reactome.py to URLZSource Dec 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.