Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split URLZSource into separate library #416

Closed
afaulconbridge opened this issue Jan 31, 2019 · 3 comments

Comments

Projects
None yet
1 participant
@afaulconbridge
Copy link

commented Jan 31, 2019

The URLZSource function is used in various places (pipeline, evidence generation, ontology-utils, validator) but has been copied each time. this means the different places have different behavrious and are drifting further apart over time.

We should put URLZSource into a separate python library (and corresponding GitHub repository) and the use that in each of the places instead. This is more maintainable and more futureproof.

@afaulconbridge

This comment has been minimized.

Copy link
Author

commented Mar 19, 2019

@afaulconbridge

This comment has been minimized.

Copy link
Author

commented Mar 19, 2019

https://pypi.org/project/opentargets-urlzsource/ created, and PR opentargets/data_pipeline#469 created to use in pipeline

needs updates to:

  • opentargets/platform-input-support
  • opentargets/ontology-utils
  • opentargets/validator
@afaulconbridge

This comment has been minimized.

Copy link
Author

commented Apr 1, 2019

Closing. #534 exists for the remaining work on the validator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.