Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GProfiler from nginx proxy #437

Closed
peatroot opened this issue Feb 12, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@peatroot
Copy link
Contributor

commented Feb 12, 2019

As part of the fix for #430, the PR opentargets/webapp#300 calls the new GProfiler API directly. As a result, the proxy settings in the rest_api can be removed. See https://github.com/opentargets/rest_api/blob/c8cac0c24c7bd15902c83233447a590d1823e0f0/docker/nginx-proxy.conf#L134-L152. It is highly unlikely the proxy adds much of a speed up for users, since batch search queries to this service are all likely to be different.

This should not be removed before the 19.04 release so as to give time to assess the changes.

@afaulconbridge

This comment has been minimized.

Copy link

commented Mar 8, 2019

moving to 19.06 since it needs to be "not before" 19.04

afaulconbridge added a commit to opentargets/rest_api that referenced this issue May 28, 2019

cmalangone added a commit to opentargets/rest_api that referenced this issue May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.