Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend crash for panel "RNA and protein baseline expression" #601

Open
pieterlukasse opened this issue May 16, 2019 · 9 comments

Comments

Projects
None yet
5 participants
@pieterlukasse
Copy link

commented May 16, 2019

The panel "RNA and protein baseline expression" crashes after opening.
Steps to reproduce:

  1. go to https://www.targetvalidation.org/target/ENSG00000282608
  2. open the "RNA and protein baseline expression" panel. Notice the error in the "Console" panel (e.g. in Chrome dev tools). See screenshot below:

image

@peatroot

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

See #127.

LucaFumis added a commit to opentargets/webapp that referenced this issue May 16, 2019

@pieterlukasse

This comment has been minimized.

Copy link
Author

commented Jun 11, 2019

Hi @LucaFumis , we tested the fix at opentargets/webapp@f2e7039, but unfortunately the result is now that none of the 3 tabs are available, while there could be data in one of them. I heard from the users/testers that the fix causes ""No data for ENSG00000282608" to be displayed, even though there is "GTEx variability" data for ENSG00000282608. Can you confirm this? If yes, then the best solution would be to disable each of the tabs separately.

@LucaFumis

This comment has been minimized.

Copy link

commented Jun 14, 2019

Hi @pieterlukasse yes, that's correct: as per latest fix we use the response for the "Summary" tab to enable/disable all tabs.
For the 2nd tab we load the Expression Atlas dependencies and that generates the widget and makes the call, so we don't access that response directly. I'll need to investigate it a bit, but I suspect we might only be able to enable/disable 1st and 3rd tab...

@pieterlukasse

This comment has been minimized.

Copy link
Author

commented Jun 21, 2019

hi @LucaFumis, thanks for the reply. Any updates on this one?

@LucaFumis

This comment has been minimized.

Copy link

commented Jun 25, 2019

Hi @pieterlukasse, I haven't had the chance to look at this in more detail unfortunately - will try do after new release is out later this week / early next week.

Cheers,
Luca

@pieterlukasse

This comment has been minimized.

Copy link
Author

commented Jun 26, 2019

Sounds good @LucaFumis. Thanks for the update!

@fedde-s

This comment has been minimized.

Copy link

commented Jul 4, 2019

Just to check—@LucaFumis, is it still on your list? The bug can still be reproduced in the version currently deployed to the public platform (3.13.1), listing that there's no data for this particular gene despite data being returned by the GTEx webservice calls.

@d0choa

This comment has been minimized.

Copy link

commented Jul 4, 2019

Hi @fedde-s, we're trying to fix the original problem on the data regarding the wrong assembly. Since the issue is just preventing some data to be shown, we are aiming for the long-term solution. Bare with us and we'll try to get this sorted once the right data flows in

@fedde-s

This comment has been minimized.

Copy link

commented Jul 5, 2019

Thanks for the update; I'll relay it to the people who were asking me about it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.