Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pathways panel in target profile page shows error instead of diagram #626

Closed
fedde-s opened this issue Jun 7, 2019 · 7 comments

Comments

Projects
None yet
4 participants
@fedde-s
Copy link

commented Jun 7, 2019

When I open the target profile page for a gene that has pathways available, say BRAF, and open the Pathways panel, I see the following error message where I'd expect a diagram:

Widget showing the text "There was a problem while loading the diagram" on a brick-red background

This occurs both on the public platform and on local deployments.

@fedde-s fedde-s changed the title *Pathways* panel in target profile page shows error instead of diagram Pathways panel in target profile page shows error instead of diagram Jun 7, 2019

@fedde-s

This comment has been minimized.

Copy link
Author

commented Jun 7, 2019

@LucaFumis, any ideas what could be going wrong here?

@afaulconbridge

This comment has been minimized.

Copy link

commented Jun 7, 2019

@fedde-s we've had a chat with the people from Reactome about this (benefits of being in the same building!) and it seems to be a CORS issue. www.reactome.org is a 301 redirect to reactome.org and reactome.org has Access-Control-Allow-Origin:* but www.reactome.org doesn't. So when javascript served from www.targetvalidation.org makes a request to www.reactome.org there is a redirect response without the CORS header, and the browser blocks following it. It's unclear why this has happened today or what has changed - Reactome will investigate more next week. Also next week @LucaFumis will check the calls the webapp makes and update them all to be directly against reactome.org

LucaFumis added a commit to opentargets/webapp that referenced this issue Jun 10, 2019

LucaFumis added a commit to opentargets/webapp that referenced this issue Jun 10, 2019

LucaFumis added a commit to opentargets/webapp that referenced this issue Jun 10, 2019

LucaFumis added a commit to opentargets/webapp that referenced this issue Jun 10, 2019

LucaFumis added a commit to opentargets/webapp that referenced this issue Jun 10, 2019

LucaFumis added a commit to opentargets/webapp that referenced this issue Jun 10, 2019

LucaFumis added a commit to opentargets/webapp that referenced this issue Jun 10, 2019

LucaFumis added a commit to opentargets/webapp that referenced this issue Jun 10, 2019

LucaFumis added a commit to opentargets/webapp that referenced this issue Jun 10, 2019

LucaFumis added a commit to opentargets/webapp that referenced this issue Jun 10, 2019

@LucaFumis

This comment has been minimized.

Copy link

commented Jun 10, 2019

That was based on the suggestion to remove 'www' from Reactome URLs, but actually introduced an error in the batch search results. This is now fixed in commit 8de31d987915548449c9262cae506eb57ceba057

I'll merge and tag that and push a mini release out.

LucaFumis added a commit to opentargets/webapp that referenced this issue Jun 10, 2019

@fedde-s

This comment has been minimized.

Copy link
Author

commented Jun 11, 2019

@LucaFumis, will there be a release tag for 3.12.3 on GitHub when it's ready?

@LucaFumis

This comment has been minimized.

Copy link

commented Jun 11, 2019

Hi @fedde-s, yes I've just merged and sorted out the tags.
There is a 3.12.3 tag in GitHub
Quay: 3.12.3 (also tagged as 19.04.7)

@ElaineMcA the mini release is now live; I've updated the log.

@LucaFumis

This comment has been minimized.

Copy link

commented Jun 11, 2019

This implements the quick fix as suggested by Reactome (i.e. removing the "www" from calls).
I believe they're investigating in parallel so there might be the need for further changes but for the time being this should work.

@ElaineMcA ElaineMcA closed this Jul 8, 2019

@fedde-s

This comment has been minimized.

Copy link
Author

commented Jul 8, 2019

Fix confirmed: when I follow the link in the original issue description, I see a diagram again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.