Functiona tests for Private nat gateway#649
Merged
Merged
Conversation
| def cleanup_stale_routers(self, prefix): | ||
| """Clean up stale Neutron routers created by functional tests.""" | ||
| for router in self.conn.network.routers(): | ||
| if not router.name or not router.name.startswith(prefix): |
Member
There was a problem hiding this comment.
need to be carefull with this, and look on prefixes, also good to add additional point to docstring
anton-sidelnikov
approved these changes
Apr 17, 2026
Contributor
|
Build succeeded. ✔️ otc-tox-docs SUCCESS in 11m 27s |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds functional tests for private nat gateway.
Details
cleanup_routershelper into base class to reuse it in bothtest_zoneandtest_private_nat_gateway