Add proxy pallet#286
Conversation
|
What is the progress on this? How soon can we get the proxy pallet merged? |
|
@camfairchild Would love to see this feature merged, as it would allow us to work with cold wallets that can stake/unstake funds using a hot wallet. As it is a standard polkadot-sdk pallet that is included in many chains, it should be relatively easy to merge, right? 🙏 |
open-junius
requested review from
a team,
distributedstatemachine,
keithtensor and
sam0x17
|
The PR is ready for review. I think the proxy types defined is flexible enough for token related, sub tensor staking and other operations. like to know more comments what's kind of type is needed from business logic |
distributedstatemachine
left a comment
distributedstatemachine
left a comment
There was a problem hiding this comment.
Left some comments . Is there a way to add tests to this ?
| parameter_types! { | ||
| // One storage item; key size is 32; value is size 4+4+16+32 bytes = 56 bytes. | ||
| pub const DepositBase: Balance = (1) as Balance * 2_000 * 10_000 + (88 as Balance) * 100 * 10_000; | ||
| pub const DepositBase: Balance = deposit(1, 88); |
There was a problem hiding this comment.
Where does this figure come from ? The calculation doesnt seem to match the comments
There was a problem hiding this comment.
From multisig pallet, I get the code as follows. the comments from substrate upstream. I will check if we should change it.
/// This is held for an additional storage item whose value size is
/// 4 + sizeof((BlockNumber, Balance, AccountId)) bytes and whose key size is
/// 32 + sizeof(AccountId) bytes.
#[pallet::constant]
type DepositBase: Get<BalanceOf>;
| ProxyType::NonFungibile => !matches!( | ||
| c, | ||
| RuntimeCall::Balances(..) | ||
| | RuntimeCall::SubtensorModule(pallet_subtensor::Call::add_stake { .. }) |
There was a problem hiding this comment.
Note to self: Rebase stao off development so we can capture this
There was a problem hiding this comment.
After rebase, the NonFungibile excludes all extrinsic related to balance in Subtensor pallet.
There was a problem hiding this comment.
ha.. this was a note for me !
There was a problem hiding this comment.
pls add stao extrinsic in filter
It is tricky to test the runtime, we can skip it for now since the pallet from upstream |
|
Hello Guys! Thank you very much for taking care of this. I´m glad to know you are testing this proxy pallet :) Do you have an estimation of the time it can take to push this to production? |
5 participants
Integrates the proxy pallet
[Needs testing]
TODO
ProxyTypefilter