Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to clear Operation Dataset when a new network parameter is set. #1639

Merged
merged 1 commit into from Apr 22, 2017
Merged

Allow to clear Operation Dataset when a new network parameter is set. #1639

merged 1 commit into from Apr 22, 2017

Conversation

LuDuda
Copy link
Member

@LuDuda LuDuda commented Apr 21, 2017

This PR introduces simple fix for #1638

@codecov-io
Copy link

codecov-io commented Apr 21, 2017

Codecov Report

Merging #1639 into master will decrease coverage by 0.49%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #1639     +/-   ##
=========================================
- Coverage   67.56%   67.07%   -0.5%     
=========================================
  Files         166      167      +1     
  Lines       21102    21109      +7     
  Branches     2588     2588             
=========================================
- Hits        14258    14158    -100     
- Misses       5936     6049    +113     
+ Partials      908      902      -6
Impacted Files Coverage Δ
src/core/meshcop/dataset_manager.cpp 73.56% <100%> (-0.43%) ⬇️
src/core/coap/coap_client.cpp 51.78% <0%> (-20.41%) ⬇️
src/core/coap/coap_client.hpp 73.33% <0%> (-20%) ⬇️
src/core/thread/lowpan.hpp 86.84% <0%> (-13.16%) ⬇️
src/core/net/ip6.cpp 55.89% <0%> (-9.91%) ⬇️
src/core/coap/coap_server.cpp 81.48% <0%> (-7.41%) ⬇️
src/core/thread/mle_router_ftd.hpp 64.28% <0%> (-7.15%) ⬇️
src/core/coap/coap_server.hpp 88.88% <0%> (-3.97%) ⬇️
src/core/net/netif.cpp 57.64% <0%> (-3.53%) ⬇️
src/core/thread/lowpan.cpp 92.47% <0%> (-1.62%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd18c0f...d074b72. Read the comment docs.

Copy link
Member

@chshu chshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@librasungirl librasungirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jwhui jwhui merged commit c9e47b1 into openthread:master Apr 22, 2017
vaas-krish pushed a commit to vaas-krish/openthread that referenced this pull request May 23, 2017
…s/github_2017_04_25 to master

* commit 'f25c6727badcddbe7d1d8263478ecb4ec6c40fec': (35 commits)
  Add `ExitNow()` in MARBLE-387 workaround path.
  Reduce MTD code size by removing some unused MeshCoP features (openthread#1361)
  Add/Update logs in `MeshForwarder` class (openthread#1649)
  Remove use of gnu-extension anonymous struct/union definitions. (openthread#1651)
  Require platform TRNG to provide requested output length or error. (openthread#1650)
  Ensure fairness in handling of data polls from sleepy children (openthread#1646)
  Update formatting in `NcpSpi` and `spi-slave.h` files (openthread#1648)
  Add EFR32 to readme. (openthread#1647)
  Add support for SiLabs EFR32. (openthread#1592)
  No payload no marker (openthread#1645)
  return the right error information for some cli commands (openthread#1644)
  Allow to clear Operation Dataset when a new network parameter is set. (openthread#1639)
  `NcpBuffer`: Fixing bug with handling of longer frame segments (openthread#1643)
  Fix inherits implicit virtual warning. (openthread#1641)
  Fix README.md command list of Diag module. (openthread#1640)
  Fix the error check for src/dst address get in `Frame::ToInfoString()` (openthread#1633)
  Set Commissioner Data when becoming Leader (openthread#1636)
  enable all features on posix (openthread#1634)
  Add `src/core` header files to PRETTY_FILES. (openthread#1632)
  Remove unnecessary configure options from pretty check. (openthread#1631)
  ...
@LuDuda LuDuda deleted the pr/fix-dataset-clear branch May 30, 2017 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants