New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[types] move types into specific headers #2946

Merged
merged 1 commit into from Aug 8, 2018

Conversation

Projects
None yet
3 participants
@jwhui
Member

jwhui commented Aug 3, 2018

Resolves #1462.

Show outdated Hide outdated include/openthread/error.h Outdated
Show outdated Hide outdated include/openthread/error.h Outdated

@jwhui jwhui requested review from Vyrastas and abtink Aug 6, 2018

@abtink

abtink approved these changes Aug 7, 2018

LGTM. One suggestion below.

*
*/
OT_TOOL_PACKED_BEGIN
struct otMasterKey

This comment has been minimized.

@abtink

abtink Aug 7, 2018

Member

How about adding otMasterKey related definitions in thread.h?

@abtink

abtink Aug 7, 2018

Member

How about adding otMasterKey related definitions in thread.h?

@jwhui jwhui merged commit 9d585ed into openthread:master Aug 8, 2018

3 checks passed

cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jwhui jwhui deleted the jwhui:types branch Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment