Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[continuous-integration] use lcov to generate coverage data #5635

Merged
merged 2 commits into from Oct 29, 2020
Merged

[continuous-integration] use lcov to generate coverage data #5635

merged 2 commits into from Oct 29, 2020

Conversation

moandor-y
Copy link
Contributor

@moandor-y moandor-y commented Oct 12, 2020 •
edited by jwhui

This PR makes it use lcov to generate the coverage report and upload using the bash script, which may be more stable.

Resolves #5628.

@google-cla google-cla bot added the cla: yes label Oct 12, 2020
@size-report
Copy link

size-report bot commented Oct 12, 2020 •
edited

Size Report of OpenThread

Merging #5635 into master(fc159a7).

name branch text data bss total
ot-cli-ftd_1.1 master 383660 736 72844 457240
#5635 383660 736 72844 457240
+/- 0 0 0 0
ot-cli-mtd_1.1 master 311100 736 64260 376096
#5635 311100 736 64260 376096
+/- 0 0 0 0
ot-ncp-ftd_1.1 master 377564 736 72124 450424
#5635 377564 736 72124 450424
+/- 0 0 0 0
ot-ncp-mtd_1.1 master 307980 736 63540 372256
#5635 307980 736 63540 372256
+/- 0 0 0 0
ot-rcp_1.1 master 64280 636 7656 72572
#5635 64280 636 7656 72572
+/- 0 0 0 0
libopenthread-cli-ftd.a_1.1 master 38300 0 3108 41408
#5635 38300 0 3108 41408
+/- 0 0 0 0
libopenthread-cli-mtd.a_1.1 master 31119 0 3108 34227
#5635 31119 0 3108 34227
+/- 0 0 0 0
libopenthread-ftd.a_1.1 master 189469 4 54992 244465
#5635 189469 4 54992 244465
+/- 0 0 0 0
libopenthread-mtd.a_1.1 master 129453 4 46408 175865
#5635 129453 4 46408 175865
+/- 0 0 0 0
libopenthread-ncp-ftd.a_1.1 master 48149 0 2388 50537
#5635 48149 0 2388 50537
+/- 0 0 0 0
libopenthread-ncp-mtd.a_1.1 master 43345 0 2388 45733
#5635 43345 0 2388 45733
+/- 0 0 0 0
libopenthread-rcp.a_1.1 master 27200 0 1532 28732
#5635 27200 0 1532 28732
+/- 0 0 0 0
libopenthread-radio.a_1.1 master 13406 0 150 13556
#5635 13406 0 150 13556
+/- 0 0 0 0
ot-cli-ftd_1.2 master 407780 736 82392 490908
#5635 407780 736 82392 490908
+/- 0 0 0 0
ot-cli-mtd_1.2 master 323396 736 64544 388676
#5635 323396 736 64544 388676
+/- 0 0 0 0
ot-ncp-ftd_1.2 master 398756 736 81672 481164
#5635 398756 736 81672 481164
+/- 0 0 0 0
ot-ncp-mtd_1.2 master 318244 736 63824 382804
#5635 318244 736 63824 382804
+/- 0 0 0 0
ot-rcp_1.2 master 70956 636 16528 88120
#5635 70956 636 16528 88120
+/- 0 0 0 0
libopenthread-cli-ftd.a_1.2 master 39949 0 3108 43057
#5635 39949 0 3108 43057
+/- 0 0 0 0
libopenthread-cli-mtd.a_1.2 master 31892 0 3108 35000
#5635 31892 0 3108 35000
+/- 0 0 0 0
libopenthread-ftd.a_1.2 master 210499 4 64440 274943
#5635 210499 4 64440 274943
+/- 0 0 0 0
libopenthread-mtd.a_1.2 master 138920 4 46592 185516
#5635 138920 4 46592 185516
+/- 0 0 0 0
libopenthread-ncp-ftd.a_1.2 master 48149 0 2388 50537
#5635 48149 0 2388 50537
+/- 0 0 0 0
libopenthread-ncp-mtd.a_1.2 master 43345 0 2388 45733
#5635 43345 0 2388 45733
+/- 0 0 0 0
libopenthread-rcp.a_1.2 master 27200 0 1532 28732
#5635 27200 0 1532 28732
+/- 0 0 0 0
libopenthread-radio.a_1.2 master 14828 0 174 15002
#5635 14828 0 174 15002
+/- 0 0 0 0

@codecov
Copy link

codecov bot commented Oct 12, 2020 •
edited

Codecov Report

Merging #5635 into master will increase coverage by 2.18%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5635      +/-   ##
==========================================
+ Coverage   84.91%   87.10%   +2.18%     
==========================================
  Files         376      368       -8     
  Lines       46569    45841     -728     
==========================================
+ Hits        39546    39928     +382     
+ Misses       7023     5913    -1110
Impacted Files Coverage Δ
src/core/backbone_router/bbr_leader.cpp 86.50% <0.00%> (-9.55%) ⬇️
src/core/utils/child_supervision.hpp 54.54% <0.00%> (-5.46%) ⬇️
src/core/net/sntp_client.hpp 75.00% <0.00%> (-5.00%) ⬇️
src/core/thread/dua_manager.cpp 82.08% <0.00%> (-1.48%) ⬇️
src/posix/platform/hdlc_interface.cpp 51.96% <0.00%> (-1.19%) ⬇️
src/core/backbone_router/bbr_manager.cpp 91.78% <0.00%> (-1.18%) ⬇️
src/core/thread/mesh_forwarder.cpp 92.34% <0.00%> (-0.89%) ⬇️
src/core/thread/csl_tx_scheduler.cpp 95.53% <0.00%> (-0.87%) ⬇️
src/core/thread/mesh_forwarder_ftd.cpp 87.75% <0.00%> (-0.52%) ⬇️
src/core/common/settings.cpp 78.73% <0.00%> (-0.46%) ⬇️
... and 68 more

@moandor-y
Copy link
Contributor Author

Codecov still shows wrong coverage data. The ProcessDns in CLI is called in expect tests but it shows uncovered: https://codecov.io/gh/openthread/openthread/src/2d2fc92b2a82f0c17b67313a39c4ab70c34127cb/src/cli/cli.cpp.
Looks like the Codecov itself is unstable.

@moandor-y moandor-y mentioned this pull request Oct 20, 2020
Closed
@moandor-y moandor-y mentioned this pull request Oct 27, 2020
Merged
simonlingoogle
simonlingoogle reviewed Oct 28, 2020
View reviewed changes
Copy link
Member

@simonlingoogle simonlingoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we adjust after_n_builds in codecov.yml too in this PR?

tests/scripts/thread-cert/node.py Outdated Show resolved Hide resolved
tests/scripts/thread-cert/node.py Outdated Show resolved Hide resolved
.github/workflows/posix.yml Outdated Show resolved Hide resolved
wgtdkp
wgtdkp approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@wgtdkp wgtdkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

bukepo
bukepo approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@bukepo bukepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

simonlingoogle
simonlingoogle reviewed Oct 29, 2020
View reviewed changes
Copy link
Member

@simonlingoogle simonlingoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM 👍

with nits

script/test Outdated Show resolved Hide resolved
script/test Outdated Show resolved Hide resolved
@moandor-y @simonlingoogle
[continuous-integration] use lcov to generate coverage data
4d0e8da 
Co-authored-by: Simon Lin <simonlin@google.com>
@jwhui jwhui merged commit 713662b into openthread:master Oct 29, 2020
@moandor-y moandor-y deleted the lcov branch October 30, 2020 10:20
simonlingoogle pushed a commit to simonlingoogle/openthread that referenced this pull request Nov 12, 2020
[Github Sync] Merge github/master to master
992f3ab 
Bug: 171933690

* origin/github/master:
  [low-power] implement forward tracking series (openthread#5608)
  [efr32] radio: increase FIFO size to allow handling of heavy traffic (openthread#5742)
  [test] verify realm-local multicast on POSIX (openthread#5738)
  [clang-tidy] google-explicit-constructor (openthread#5734)
  [clang-tidy] misc-unused-using-decls (openthread#5732)
  [continuous-integration] use lcov to generate coverage data (openthread#5635)
  [type-traits] add 'IsPointer<Type>' and use it in message/dataset (openthread#5735)
  [posix] set default IPv6 hop limit to OPENTHREAD_CONFIG_IP6_HOP_LIMIT_DEFAULT (openthread#5736)
  [net-diag] invoke the callback when failed to get the response (openthread#5653)
  [site] fix border router guide typo in network (openthread#5731)
  [cli] update cli doc (openthread#5729)
  [thread-cert] refactor case 5.1.3 using pktverify (openthread#5708)
  [thread-cert] refactor case 5.1.2 using pktverify (openthread#5686)
  [test] arm build with cmake 3.10 (openthread#5727)
  [clang-tidy] google-readability-casting (openthread#5720)
  [clang-tidy] modernize-use-equals-default (openthread#5719)
  [clang-tidy] readability-avoid-const-params-in-decls (openthread#5717)
  [clang-tidy] modernize-use-equals-delete (openthread#5718)
  [efr32] add MG21/BRD4180B support (openthread#5725)
  [posix] fix cast-align build error on ARM (openthread#5672)
  [logging] add optional `otPlatLogLine()` & use it in NCP/CLI (openthread#5704)
  [clang-tidy] readability-simplify-boolean-expr (openthread#5716)
  [clang-tidy] modernize-use-nullptr (openthread#5715)
  [dataset] add new helper 'SetTlv()' with a template 'ValueType' (openthread#5722)
  [dataset-manager] simplify 'SendSetRequest()' (openthread#5721)
  [nrf528xx] fix SPI issue (openthread#5703)
  [clang-tidy] modernize-use-bool-literals (openthread#5714)
  [cmake] no target_link_options in cmake 3.10 (openthread#5706)
  [low-power] enhance CSL transmission on NRF52840 using `transmit_at` (openthread#5545)
  [build] fix warning of clearing non-trivial type (openthread#5710)
  [scripts] add MLR Backbone multicast routing test (openthread#5578)
  [mlr] fix build when OPENTHREAD_CONFIG_IP6_SLAAC_ENABLE is disabled (openthread#5711)
  [cmake] use init flags in toolchain files (openthread#5705)
  [cmake] set default build type to Debug (openthread#5709)
  [thread-cert] refactor case 5.1.1 using pktverify (openthread#5680)
  [posix] fix udp close (openthread#5690)
Change-Id: Ic7e4051040f093aa6dce9de5e2031a8accddec87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bukepo bukepo bukepo approved these changes

@wgtdkp wgtdkp wgtdkp approved these changes

@jwhui jwhui jwhui approved these changes

@simonlingoogle simonlingoogle simonlingoogle approved these changes

Assignees
No one assigned
Labels
cla: yes continuous-integration P4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[codecov] code coverage threshold check is failing
5 participants
@moandor-y @bukepo @wgtdkp @jwhui @simonlingoogle