fix(popper): [tooltip,popover] fix popper doms in custom element, cant get zindex #3126
Conversation
WalkthroughThe changes update three functions across different modules to improve support for Shadow DOM elements. In each case, the logic now checks for the presence of a Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant Function
participant Element
Caller->>Function: Call function with element
Function->>Element: Check for 'host' property
alt Element has 'host'
Element-->>Function: Return host
Function->>Function: Reassign element = element.host
else No host
Element-->>Function: Continue with original element
end
Function->>Caller: Return processed result
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
ERR_PNPM_OPTIONAL_DEPS_REQUIRE_PROD_DEPS Optional dependencies cannot be installed without production dependencies Tip ⚡🧪 Multi-step agentic review comment chat (experimental)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis PR addresses an issue with the popper component when used inside custom elements. It fixes errors related to finding parent nodes and retrieving the z-index by handling cases where shadow DOMs are involved. Changes
|
![petercat-assistant[bot]](https://avatars.githubusercontent.com/in/875736?s=60&v=4){kind=small}
| el = el.host | ||
| } | ||
|
|
||
| return (' ' + el.getAttribute('data-tag') + ' ').includes(' ' + value + ' ') |
There was a problem hiding this comment.
Ensure that el.getAttribute('data-tag') is not null before using it in the includes method to avoid potential runtime errors.
| if (el.host) { | ||
| el = el.host | ||
| } | ||
| return el.parentNode ? isFixed(el.parentNode as HTMLElement) : false |
There was a problem hiding this comment.
Ensure that el.parentNode is not null before passing it to isFixed to avoid potential runtime errors.
| reference = reference.host | ||
| } | ||
|
|
||
| if (reference) { |
There was a problem hiding this comment.
Ensure that getZIndex(reference) handles cases where reference might not have a valid z-index to avoid potential runtime errors.
PR
PR Checklist
修复popper用在自定义元素内部时，向上找父节点报错的问题。 ---- 同步代码
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit