fix: Fix SaaS theme packaging error issue #3250

chenxi-20 · 2025-04-07T03:38:18Z

PR

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

Style
- Updated skeleton loader appearances with a refreshed background style for smooth, modern loading visuals.
- Refined theme background settings by introducing a custom sizing option, providing a more consistent and streamlined visual presentation.

coderabbitai · 2025-04-07T03:38:24Z

Walkthrough

The changes remove references to the backgroundSize property from the layout handling in the theme package and update the background styling for skeleton items. In the loadTheme.js file, code that processes backgroundSize is eliminated. Corresponding CSS classes in both the Less and Vue files have been updated from bg-200-100 to bg-w200h100. Additionally, the Tailwind CSS configuration now deletes the old background size setting and adds a new custom mapping, while the default theme no longer exports any background size property.

Changes

File(s)	Change Summary
packages/theme-saas/plugins/loadTheme.js	Removed extraction and processing of `backgroundSize` from the Layout object, so it is no longer included in the returned layout tokens.
packages/theme-saas/src/skeleton-item/index.less packages/vue/src/skeleton-item/src/mobile-first.vue	Updated the skeleton item's active state class from `bg-200-100` to `bg-w200h100`, altering the background styling for loading animations.
packages/theme-saas/tailwind.config.js	Removed the `backgroundSize` property from the main theme configuration and introduced a new custom mapping (`'w200h100': '200% 100%'`) within the `extend` section.
packages/theme-saas/theme/defaultTheme.js	Removed the `backgroundSize` property (with key `'200-100'` set to `'200% 100%'`) from the exported theme object.

Sequence Diagram(s)

sequenceDiagram
    participant LT as LoadTheme Function
    participant TC as Tailwind Config
    participant SC as Skeleton Component

    LT ->> LT: Process layout (excluding backgroundSize)
    LT ->> TC: Provide layout tokens without backgroundSize
    TC ->> TC: Initialize new backgroundSize config ('w200h100': '200% 100%')
    TC ->> SC: Supply updated styling classes
    SC ->> User: Render skeleton with new bg-w200h100 class

Suggested reviewers

zzcr

Poem

In the code garden, I hop with delight,
Old background styles fade into the night.
New classes bloom with a vibrant twist,
Like carrots in a field, perfectly kissed.
I celebrate these changes with a joyful bound—
A rabbit’s cheer in every line found!

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

WARN GET http://10.0.0.28:4873/@antfu%2Feslint-config error (503). Will retry in 10 seconds. 2 retries left.
WARN GET http://10.0.0.28:4873/@types%2Feslint error (503). Will retry in 10 seconds. 2 retries left.
WARN GET http://10.0.0.28:4873/@volar-plugins%2Feslint error (503). Will retry in 10 seconds. 2 retries left.
WARN GET http://10.0.0.28:4873/eslint-config-prettier error (503). Will retry in 10 seconds. 2 retries left.
WARN GET http://10.0.0.28:4873/@typescript-eslint%2Fparser error (503). Will retry in 10 seconds. 2 retries left.
WARN GET http://10.0.0.28:4873/eslint-plugin-prettier error (503). Will retry in 10 seconds. 2 retries left.
WARN GET http://10.0.0.28:4873/eslint error (503). Will retry in 10 seconds. 2 retries left.
WARN GET http://10.0.0.28:4873/prettier error (503). Will retry in 10 seconds. 2 retries left.
WARN GET http://10.0.0.28:4873/typescript error (503). Will retry in 10 seconds. 2 retries left.
WARN GET http://10.0.0.28:4873/vue error (503). Will retry in 10 seconds. 2 retries left.
WARN GET http://10.0.0.28:4873/@volar-plugins%2Fprettier error (503). Will retry in 10 seconds. 2 retries left.
WARN GET http://10.0.0.28:4873/@vue%2Ftsconfig error (503). Will retry in 10 seconds. 2 retries left.
WARN GET http://10.0.0.28:4873/fs-extra error (503). Will retry in 10 seconds. 2 retries left.
WARN GET http://10.0.0.28:4873/@antfu%2Feslint-config error (503). Will retry in 1 minute. 1 retries left.
WARN GET http://10.0.0.28:4873/@types%2Feslint error (503). Will retry in 1 minute. 1 retries left.
WARN GET http://10.0.0.28:4873/@volar-plugins%2Feslint error (503). Will retry in 1 minute. 1 retries left.
WARN GET http://10.0.0.28:4873/eslint-config-prettier error (503). Will retry in 1 minute. 1 retries left.
WARN GET http://10.0.0.28:4873/@typescript-eslint%2Fparser error (503). Will retry in 1 minute. 1 retries left.
WARN GET http://10.0.0.28:4873/eslint-plugin-prettier error (503). Will retry in 1 minute. 1 retries left.
WARN GET http://10.0.0.28:4873/eslint error (503). Will retry in 1 minute. 1 retries left.
WARN GET http://10.0.0.28:4873/prettier error (503). Will retry in 1 minute. 1 retries left.
WARN GET http://10.0.0.28:4873/typescript error (503). Will retry in 1 minute. 1 retries left.
WARN GET http://10.0.0.28:4873/vue error (503). Will retry in 1 minute. 1 retries left.
WARN GET http://10.0.0.28:4873/@vue%2Ftsconfig error (503). Will retry in 1 minute. 1 retries left.
WARN GET http://10.0.0.28:4873/fs-extra error (503). Will retry in 1 minute. 1 retries left.
WARN GET http://10.0.0.28:4873/@volar-plugins%2Fprettier error (503). Will retry in 1 minute. 1 retries left.
ERR_PNPM_FETCH_503 GET http://10.0.0.28:4873/@antfu%2Feslint-config: Service Unavailable - 503

This error happened while installing a direct dependency of /tmp/eslint

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 87c5286 and 34e8756.

📒 Files selected for processing (5)

packages/theme-saas/plugins/loadTheme.js (0 hunks)
packages/theme-saas/src/skeleton-item/index.less (1 hunks)
packages/theme-saas/tailwind.config.js (1 hunks)
packages/theme-saas/theme/defaultTheme.js (0 hunks)
packages/vue/src/skeleton-item/src/mobile-first.vue (1 hunks)

💤 Files with no reviewable changes (2)

packages/theme-saas/plugins/loadTheme.js
packages/theme-saas/theme/defaultTheme.js

🔇 Additional comments (3)

packages/theme-saas/src/skeleton-item/index.less (1)

15-15: Class naming convention updated to improve clarity.

The change from bg-200-100 to bg-w200h100 makes the background size property more explicit and descriptive, indicating a width of 200% and height of 100%. This aligns with the updated configuration in the Tailwind setup.

packages/vue/src/skeleton-item/src/mobile-first.vue (1)

12-12: Updated class name for consistency with theme changes.

The class has been properly updated from bg-200-100 to bg-w200h100 to match the corresponding change in the LESS file. This ensures consistent styling across component implementations.

packages/theme-saas/tailwind.config.js (1)

25-27: Added explicit backgroundSize in extend section to fix packaging error.

This change addresses the core packaging issue by:

Moving away from the dynamic loading of background sizes from layout tokens

Explicitly defining the needed background size with a more descriptive name

The explicit definition ensures the required style is always available during packaging, preventing the error mentioned in the PR title.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai plan to trigger planning for file edits and PR creation.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

github-actions · 2025-04-07T03:38:44Z

[e2e-test-warn]
The component to be tested is missing.

The title of the Pull request should look like "fix(vue-renderless): [action-menu, alert] fix xxx bug".

Please make sure you've read our contributing guide

fix: 修复saas主题打包报错问题

34e8756

chenxi-20 added the bug Something isn't working label Apr 7, 2025

zzcr approved these changes Apr 7, 2025

View reviewed changes

zzcr merged commit 1babf3a into dev Apr 7, 2025
11 checks passed

kagol deleted the fix/build-sass-20250407 branch April 14, 2025 12:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Fix SaaS theme packaging error issue #3250

fix: Fix SaaS theme packaging error issue #3250

Uh oh!

chenxi-20 commented Apr 7, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 7, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: Fix SaaS theme packaging error issue #3250

fix: Fix SaaS theme packaging error issue #3250

Uh oh!

Conversation

chenxi-20 commented Apr 7, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

github-actions bot commented Apr 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chenxi-20 commented Apr 7, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)