Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up window events. #967

Merged
merged 4 commits into from Oct 2, 2019
Merged

Clean up window events. #967

merged 4 commits into from Oct 2, 2019

Conversation

PJB3005
Copy link
Member

@PJB3005 PJB3005 commented Sep 29, 2019

Removed all uses of EventHandler. All events are now Action.
Events whose argument was plain EventArgs have no arguments anymore.
Removed events raised purely by editing properties like TitleChanged.
Removed Disposed event (object resurrection bad)

Removed all uses of EventHandler. All events are now Action.
Events whose argument was plain EventArgs have no arguments anymore.
Removed events raised purely by editing properties like TitleChanged.
Removed Disposed event (object resurrection bad)
@PJB3005 PJB3005 mentioned this pull request Sep 30, 2019
Copy link
Member

@varon varon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice reduction and simplification of code.

Great stuff!

@varon varon merged commit 8003d08 into opentk:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants