Skip to content

Ensure that using a sensitive path for templatefile that it doesnt panic#1801

Merged
cam72cam merged 4 commits into
mainfrom
sensitive-templatefile
Jul 23, 2024
Merged

Ensure that using a sensitive path for templatefile that it doesnt panic#1801
cam72cam merged 4 commits into
mainfrom
sensitive-templatefile

Conversation

@Yantrio

@Yantrio Yantrio commented Jul 11, 2024

Copy link
Copy Markdown
Member

Resolves #1798

Target Release

1.8.0

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

Website/documentation checklist

  • I have locally started the website as described here and checked my changes.

@Yantrio Yantrio requested a review from a team as a code owner July 11, 2024 14:02
@github-actions

Copy link
Copy Markdown

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

Comment thread internal/lang/funcs/filesystem.go Outdated
Comment thread internal/lang/funcs/filesystem.go Outdated
Yantrio added 4 commits July 23, 2024 13:56
Signed-off-by: James Humphries <james@james-humphries.co.uk>
Signed-off-by: James Humphries <james@james-humphries.co.uk>
Signed-off-by: James Humphries <james@james-humphries.co.uk>
Signed-off-by: James Humphries <james@james-humphries.co.uk>
@Yantrio Yantrio force-pushed the sensitive-templatefile branch from b756606 to ce24e2d Compare July 23, 2024 12:56
@Yantrio Yantrio requested a review from cam72cam July 23, 2024 12:57
@cam72cam cam72cam merged commit 89926cc into main Jul 23, 2024
@cam72cam cam72cam deleted the sensitive-templatefile branch July 23, 2024 13:06
@github-actions

Copy link
Copy Markdown

Error: Cherry-pick commit 'eaa758e746acee41aa78db4bf474f750f4402722' failed during the backport process to 'v1.8'. Please resolve any conflicts and manually apply the changes.

Yantrio added a commit that referenced this pull request Jul 23, 2024
…nic (#1801)

Signed-off-by: James Humphries <james@james-humphries.co.uk>
cam72cam pushed a commit that referenced this pull request Jul 23, 2024
…#1846)

Signed-off-by: James Humphries <james@james-humphries.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Panic on sensitive template values

2 participants