Skip to content

Fix missing module source panic#1888

Merged
cam72cam merged 1 commit into
mainfrom
1887_fix_missing_module_source
Aug 5, 2024
Merged

Fix missing module source panic#1888
cam72cam merged 1 commit into
mainfrom
1887_fix_missing_module_source

Conversation

@cam72cam

@cam72cam cam72cam commented Aug 5, 2024

Copy link
Copy Markdown
Member

Crash should instead be a diags error

Resolves #1887

Target Release

1.9.0, 1.8.1

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

Website/documentation checklist

  • I have locally started the website as described here and checked my changes.

@cam72cam cam72cam requested a review from a team as a code owner August 5, 2024 15:32
@github-actions

github-actions Bot commented Aug 5, 2024

Copy link
Copy Markdown

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

ollevche
ollevche previously approved these changes Aug 5, 2024
Crash should instead be a diags error

Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
@cam72cam cam72cam merged commit 6f01428 into main Aug 5, 2024
@cam72cam cam72cam deleted the 1887_fix_missing_module_source branch August 5, 2024 16:12
cam72cam added a commit that referenced this pull request Aug 5, 2024
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
cam72cam added a commit that referenced this pull request Aug 5, 2024
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tofu init crashes for modules without source

2 participants