Fix all unknown block not outputted #1948
Merged
cam72cam merged 3 commits intoSep 17, 2024
Merged
Conversation
|
Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR. |
Signed-off-by: buraksenn <buraksenb@gmail.com>
…buraksenb@gmail.com> Signed-off-by: buraksenn <buraksenb@gmail.com>
buraksenn
commented
Aug 27, 2024
9 tasks
ollevche
reviewed
Sep 16, 2024
Contributor
ollevche
left a comment
There was a problem hiding this comment.
Thank you for the PR! Overall looks nice, left a minor enhancement comment.
…nb@gmail.com> Signed-off-by: buraksenn <buraksenb@gmail.com>
ollevche
approved these changes
Sep 17, 2024
cam72cam
approved these changes
Sep 17, 2024
Member
|
Thanks @buraksenn, sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1805
Plan diff needs to show nested unknown blocks but it does not. Thus, this PR implements required change for it
Target Release
1.9.0
Checklist
Go checklist