Skip to content

Fix all unknown block not outputted #1948

Merged
cam72cam merged 3 commits into
opentofu:mainfrom
buraksenn:1805-fix-all-unknown-block-not-outputted
Sep 17, 2024
Merged

Fix all unknown block not outputted #1948
cam72cam merged 3 commits into
opentofu:mainfrom
buraksenn:1805-fix-all-unknown-block-not-outputted

Conversation

@buraksenn
Copy link
Copy Markdown
Contributor

Resolves #1805

Plan diff needs to show nested unknown blocks but it does not. Thus, this PR implements required change for it

Target Release

1.9.0

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.
  • I (and other contributors to this PR) have not looked at the Terraform source code while implementing this PR.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

@buraksenn buraksenn requested a review from a team as a code owner August 27, 2024 20:20
@github-actions
Copy link
Copy Markdown

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

Signed-off-by: buraksenn <buraksenb@gmail.com>
…buraksenb@gmail.com>

Signed-off-by: buraksenn <buraksenb@gmail.com>
Comment thread internal/command/jsonformat/differ/block.go
Copy link
Copy Markdown
Contributor

@ollevche ollevche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! Overall looks nice, left a minor enhancement comment.

…nb@gmail.com>

Signed-off-by: buraksenn <buraksenb@gmail.com>
@cam72cam
Copy link
Copy Markdown
Member

Thanks @buraksenn, sorry for the delay

@cam72cam cam72cam merged commit 854c49e into opentofu:main Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plan output would miss a dynamic block if it is fully unknown

3 participants