Skip to content

Prevents providers mirror from crashing with bad lock file#1985

Merged
cam72cam merged 1 commit into
mainfrom
1800/provider_mirror_panic
Sep 25, 2024
Merged

Prevents providers mirror from crashing with bad lock file#1985
cam72cam merged 1 commit into
mainfrom
1800/provider_mirror_panic

Conversation

@Andrew-Hayes
Copy link
Copy Markdown

@Andrew-Hayes Andrew-Hayes commented Sep 12, 2024 •
edited
Loading

Resolves #1800

Prevents bad lock file from causing tofu to panic

Target Release

1.9.0

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.
  • I (and other contributors to this PR) have not looked at the Terraform source code while implementing this PR.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

Website/documentation checklist

  • I have locally started the website as described here and checked my changes.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 12, 2024

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

@Andrew-Hayes Andrew-Hayes force-pushed the 1800/provider_mirror_panic branch from aa05caf to a8558e9 Compare September 13, 2024 12:39
@Andrew-Hayes Andrew-Hayes marked this pull request as ready for review September 13, 2024 13:05
@Andrew-Hayes Andrew-Hayes requested a review from a team as a code owner September 13, 2024 13:05
@Andrew-Hayes Andrew-Hayes force-pushed the 1800/provider_mirror_panic branch 2 times, most recently from 1d844d3 to 075961e Compare September 25, 2024 09:28
Prevents providers mirror from crashing with bad lock file
9ade3e6 
Signed-off-by: Andrew Hayes <andrew.hayes@harness.io>
@Andrew-Hayes Andrew-Hayes force-pushed the 1800/provider_mirror_panic branch from 075961e to 9ade3e6 Compare September 25, 2024 09:29
@cam72cam cam72cam merged commit 20187d8 into main Sep 25, 2024
@cam72cam cam72cam deleted the 1800/provider_mirror_panic branch September 25, 2024 13:01
MS99-9 pushed a commit to MS99-9/opentofu that referenced this pull request Oct 17, 2024
@MS99-9
Prevents providers mirror from crashing with bad lock file (opentofu#…
c90b29d 
…1985)

Signed-off-by: Andrew Hayes <andrew.hayes@harness.io>
Signed-off-by: Mohamed Medhat Mohamed Ibrahim Shalaby <mohamed.shalaby@tum.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cam72cam cam72cam cam72cam approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Provider mirror fails with incomplete lock file

2 participants

@Andrew-Hayes @cam72cam