Skip to content

fix config generation with optional empty sensitive string#1986

Merged
cam72cam merged 2 commits into
mainfrom
fix-config-gen-marks
Sep 18, 2024
Merged

fix config generation with optional empty sensitive string#1986
cam72cam merged 2 commits into
mainfrom
fix-config-gen-marks

Conversation

@ollevche
Copy link
Copy Markdown
Contributor

@ollevche ollevche commented Sep 13, 2024

Resolves #1984

This PR fixes configuration generation on import when an empty string value is marked as sensitive.

Target Release

1.9.0

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.
  • I (and other contributors to this PR) have not looked at the Terraform source code while implementing this PR.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

Signed-off-by: ollevche <ollevche@gmail.com>
@ollevche ollevche requested a review from a team as a code owner September 13, 2024 11:18
@github-actions
Copy link
Copy Markdown

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

@ollevche ollevche changed the title fix config generation with optional empty sensitive strings fix config generation with optional empty sensitive string Sep 13, 2024
Comment thread internal/genconfig/generate_config.go
Signed-off-by: ollevche <ollevche@gmail.com>
Copy link
Copy Markdown
Contributor

@Evi1Pumpkin Evi1Pumpkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cam72cam cam72cam merged commit d896e93 into main Sep 18, 2024
@cam72cam cam72cam deleted the fix-config-gen-marks branch September 18, 2024 15:10
Yantrio pushed a commit that referenced this pull request Oct 23, 2024
Signed-off-by: ollevche <ollevche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenTofu Crash during tofu plan Command with AWS Elasticache Import

3 participants