Bumped go-cty-yaml to v1.1.0#2044
Merged
Christian Mesh (cam72cam) merged 2 commits intoOct 4, 2024
Merged
Conversation
|
Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR. |
Member
|
Tibo Beijen (@TBeijen) thanks for the PR, looking forward to reviewing when you are ready! |
Signed-off-by: Tibo Beijen <tibobeijen@gmail.com>
Signed-off-by: Tibo Beijen <tibobeijen@gmail.com>
9370edd to
519d4ba
Compare
Contributor
Author
|
Christian Mesh (@cam72cam) Should be ok now, although I have some tests failing. But they also fail on
|
Christian Mesh (cam72cam)
approved these changes
Oct 3, 2024
Member
|
Thanks Tibo Beijen (@TBeijen) ! |
MS99-9
pushed a commit
to MS99-9/opentofu
that referenced
this pull request
Oct 20, 2024
Signed-off-by: Tibo Beijen <tibobeijen@gmail.com> Signed-off-by: Mohamed Medhat Mohamed Ibrahim Shalaby <mohamed.shalaby@tum.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1228
Bumped go-cty-yaml to v1.1.0. Yaml number parsing is now fully according to YAML spec. See go-cty-yaml v1.1.0 CHANGELOG for details.
Note: Similar PR created for Terraform. I believe this does not constitute 'have looked at Terraform source code'. Real work is in library go-cty-yaml.
Target Release
1.9.0
Checklist
Go checklist
Website/documentation checklist