Skip to content

Bumped go-cty-yaml to v1.1.0#2044

Merged
Christian Mesh (cam72cam) merged 2 commits into
opentofu:mainfrom
TBeijen:go-cty-yaml-bump
Oct 4, 2024
Merged

Bumped go-cty-yaml to v1.1.0#2044
Christian Mesh (cam72cam) merged 2 commits into
opentofu:mainfrom
TBeijen:go-cty-yaml-bump

Conversation

@TBeijen

@TBeijen Tibo Beijen (TBeijen) commented Oct 3, 2024

Copy link
Copy Markdown
Contributor

Resolves #1228

Bumped go-cty-yaml to v1.1.0. Yaml number parsing is now fully according to YAML spec. See go-cty-yaml v1.1.0 CHANGELOG for details.

Note: Similar PR created for Terraform. I believe this does not constitute 'have looked at Terraform source code'. Real work is in library go-cty-yaml.

Target Release

1.9.0

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.
  • I (and other contributors to this PR) have not looked at the Terraform source code while implementing this PR.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

Website/documentation checklist

  • I have locally started the website as described here and checked my changes.

@github-actions

github-actions Bot commented Oct 3, 2024

Copy link
Copy Markdown

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

@cam72cam

Copy link
Copy Markdown
Member

Tibo Beijen (@TBeijen) thanks for the PR, looking forward to reviewing when you are ready!

Signed-off-by: Tibo Beijen <tibobeijen@gmail.com>
Signed-off-by: Tibo Beijen <tibobeijen@gmail.com>
@TBeijen Tibo Beijen (TBeijen) marked this pull request as ready for review October 3, 2024 17:52
@TBeijen Tibo Beijen (TBeijen) requested a review from a team as a code owner October 3, 2024 17:52
@TBeijen

Copy link
Copy Markdown
Contributor Author

Christian Mesh (@cam72cam) Should be ok now, although I have some tests failing. But they also fail on main. Something related to:

"example.com/awesomecorp/happycloud" does not offer a OpenTofu provider registry

@cam72cam Christian Mesh (cam72cam) merged commit 26fd639 into opentofu:main Oct 4, 2024
@cam72cam

Copy link
Copy Markdown
Member

Thanks Tibo Beijen (@TBeijen) !

MS99-9 pushed a commit to MS99-9/opentofu that referenced this pull request Oct 20, 2024
Signed-off-by: Tibo Beijen <tibobeijen@gmail.com>
Signed-off-by: Mohamed Medhat Mohamed Ibrahim Shalaby <mohamed.shalaby@tum.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

yamldecode fails on strings of only + (upstream go-cty-yaml issue)

2 participants