Skip to content

Handle static variable secret flag#2045

Merged
cam72cam merged 3 commits into
mainfrom
handle_static_variable_secrets
Oct 3, 2024
Merged

Handle static variable secret flag#2045
cam72cam merged 3 commits into
mainfrom
handle_static_variable_secrets

Conversation

@cam72cam

@cam72cam cam72cam commented Oct 3, 2024

Copy link
Copy Markdown
Member

See advisory: GHSA-wpr2-j6gr-pjw9

Target Release

1.9.0, 1.8.x

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.
  • I (and other contributors to this PR) have not looked at the Terraform source code while implementing this PR.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

Website/documentation checklist

  • I have locally started the website as described here and checked my changes.

@cam72cam cam72cam requested a review from a team as a code owner October 3, 2024 14:35
@github-actions

github-actions Bot commented Oct 3, 2024

Copy link
Copy Markdown

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

@cam72cam
Properly handle sensitive values in static context
a56497b 
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
@cam72cam
Add tests for sensitive values used in static contexts
bbd3c9a 
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
@cam72cam
Cleaner implementation if sensitive static vars
97d0e80 
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
@cam72cam cam72cam force-pushed the handle_static_variable_secrets branch from 8ab6c31 to 97d0e80 Compare October 3, 2024 14:36
@cam72cam cam72cam changed the title Handle static variable secrets Handle static variable secret flag Oct 3, 2024
Andrew-Hayes
Andrew-Hayes reviewed Oct 3, 2024
View reviewed changes
Comment thread internal/configs/testdata/error-files/module-sensitive.tf
Andrew-Hayes
Andrew-Hayes approved these changes Oct 3, 2024
View reviewed changes

@Andrew-Hayes Andrew-Hayes left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cam72cam cam72cam merged commit 0d1e6cd into main Oct 3, 2024
@cam72cam cam72cam deleted the handle_static_variable_secrets branch October 3, 2024 14:47
cam72cam added a commit that referenced this pull request Oct 3, 2024
@cam72cam
Handle static variable secret flag (#2045)
6f6d77f 
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
@cam72cam cam72cam mentioned this pull request Oct 3, 2024
Merged
MS99-9 pushed a commit to MS99-9/opentofu that referenced this pull request Oct 20, 2024
@cam72cam @MS99-9
Handle static variable secret flag (opentofu#2045)
1e1b2ef 
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Signed-off-by: Mohamed Medhat Mohamed Ibrahim Shalaby <mohamed.shalaby@tum.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Andrew-Hayes Andrew-Hayes Andrew-Hayes approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cam72cam @Andrew-Hayes