Skip to content

Ensure config generation does not crash when importing sensitive values#2077

Merged
James Humphries (Yantrio) merged 2 commits into
mainfrom
config-generation-crash
Oct 23, 2024
Merged

Ensure config generation does not crash when importing sensitive values#2077
James Humphries (Yantrio) merged 2 commits into
mainfrom
config-generation-crash

Conversation

@Yantrio

@Yantrio James Humphries (Yantrio) commented Oct 16, 2024

Copy link
Copy Markdown
Member

Resolves #2071

Target Release

1.9.0

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.
  • I (and other contributors to this PR) have not looked at the Terraform source code while implementing this PR.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

Signed-off-by: James Humphries <james@james-humphries.co.uk>
Signed-off-by: James Humphries <james@james-humphries.co.uk>
@Yantrio James Humphries (Yantrio) requested a review from a team as a code owner October 16, 2024 16:09
@github-actions

Copy link
Copy Markdown

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

@Yantrio James Humphries (Yantrio) deleted the config-generation-crash branch October 23, 2024 14:32
James Humphries (Yantrio) added a commit that referenced this pull request Oct 23, 2024
…es (#2077)

Signed-off-by: James Humphries <james@james-humphries.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crash doing plan -generate-config-out

3 participants