Skip to content

Partially unknown provider functions arguments fixed#2127

Merged
cam72cam merged 1 commit into
mainfrom
2126_provider_functions_partially_known_parameters
Nov 4, 2024
Merged

Partially unknown provider functions arguments fixed#2127
cam72cam merged 1 commit into
mainfrom
2126_provider_functions_partially_known_parameters

Conversation

@cam72cam
Copy link
Copy Markdown
Member

@cam72cam cam72cam commented Oct 31, 2024

Provider function arguments now respect the protocol's definition that function inputs should be checked against IsWhollyKnown in addition to the standard IsKnown.

This is different than the cty convention and has been documented as such

Resolves #2126

Target Release

1.9.0, 1.8.x, 1.7.x

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.
  • I (and other contributors to this PR) have not looked at the Terraform source code while implementing this PR.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

Website/documentation checklist

  • I have locally started the website as described here and checked my changes.

Provider function arguments now respect the protocol's definition
that function inputs should be checked against IsWhollyKnown in
addition to the standard IsKnown.

This is different than the cty convention and has been documented as
such

Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
@cam72cam cam72cam requested a review from a team as a code owner October 31, 2024 19:12
@github-actions
Copy link
Copy Markdown

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

@cam72cam cam72cam merged commit 1155a3f into main Nov 4, 2024
@cam72cam cam72cam deleted the 2126_provider_functions_partially_known_parameters branch November 4, 2024 19:23
cam72cam added a commit that referenced this pull request Nov 4, 2024
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
cam72cam added a commit that referenced this pull request Nov 4, 2024
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
cam72cam added a commit that referenced this pull request Nov 4, 2024
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
cam72cam added a commit that referenced this pull request Nov 4, 2024
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
cam72cam added a commit that referenced this pull request Nov 4, 2024
Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
cam72cam added a commit that referenced this pull request Nov 4, 2024
…2134)

Signed-off-by: Christian Mesh <christianmesh1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenTofu passes unknown values to custom functions as unitialized structs

3 participants