fix mock provider validation#2140
Merged
Merged
Conversation
|
Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR. |
Contributor
Author
|
The fix should also be backported to OpenTofu 1.8 |
93fd301 to
840f142
Compare
dc04c21 to
7a877db
Compare
cam72cam
reviewed
Nov 19, 2024
Signed-off-by: ollevche <ollevche@gmail.com>
Signed-off-by: ollevche <ollevche@gmail.com>
Signed-off-by: ollevche <ollevche@gmail.com>
Signed-off-by: ollevche <ollevche@gmail.com>
Signed-off-by: ollevche <ollevche@gmail.com>
Signed-off-by: ollevche <ollevche@gmail.com>
Signed-off-by: ollevche <ollevche@gmail.com>
f3d0710 to
b2f46ba
Compare
cam72cam
approved these changes
Nov 20, 2024
ollevche
added a commit
that referenced
this pull request
Nov 20, 2024
Signed-off-by: ollevche <ollevche@gmail.com>
4 tasks
ollevche
added a commit
that referenced
this pull request
Nov 20, 2024
apparentlymart
pushed a commit
that referenced
this pull request
Dec 3, 2024
Signed-off-by: ollevche <ollevche@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2139
Resolves #2038
In the initial implementation of mock providers, I missed that the validation of the provider block must also be skipped. In this PR I disable
ValidateProviderConfigcalls and remove provider-related schemas fromGetProviderSchemacall for any mocked provider.Target Release
1.9.0
Checklist
Go checklist