Skip to content

fix mock type conversion in tofu test#2144

Merged
ollevche merged 2 commits into
mainfrom
fix-mock-type-conversion
Nov 20, 2024
Merged

fix mock type conversion in tofu test#2144
ollevche merged 2 commits into
mainfrom
fix-mock-type-conversion

Conversation

@ollevche

@ollevche ollevche commented Nov 6, 2024

Copy link
Copy Markdown
Contributor

Resolves #2008
Resolves #1837
Part of #2139

Target Release

1.9.0

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.
  • I (and other contributors to this PR) have not looked at the Terraform source code while implementing this PR.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

@github-actions

github-actions Bot commented Nov 6, 2024

Copy link
Copy Markdown

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

@ollevche
ollevche marked this pull request as ready for review November 6, 2024 13:49
@ollevche
ollevche requested a review from a team as a code owner November 6, 2024 13:49
@ollevche

ollevche commented Nov 6, 2024

Copy link
Copy Markdown
Contributor Author

The fix should also be backported to OpenTofu 1.8

cam72cam
cam72cam previously approved these changes Nov 19, 2024
cam72cam
cam72cam previously approved these changes Nov 20, 2024
Signed-off-by: ollevche <ollevche@gmail.com>
Signed-off-by: ollevche <ollevche@gmail.com>
@ollevche
ollevche merged commit 7645992 into main Nov 20, 2024
@ollevche
ollevche deleted the fix-mock-type-conversion branch November 20, 2024 15:47
ollevche added a commit that referenced this pull request Nov 20, 2024
Signed-off-by: ollevche <ollevche@gmail.com>
ollevche added a commit that referenced this pull request Nov 21, 2024
Signed-off-by: ollevche <ollevche@gmail.com>
apparentlymart pushed a commit that referenced this pull request Dec 3, 2024
Signed-off-by: ollevche <ollevche@gmail.com>
Gogotchuri pushed a commit that referenced this pull request Dec 6, 2024
Signed-off-by: ollevche <ollevche@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

issues with override_data in test mock resource values that require set of objects are interpreted as tuple of objects and thus not set

2 participants