Skip imports on tofu destroy#2214
Merged
Merged
Conversation
Signed-off-by: Ronny Orot <ronny.orot@gmail.com>
|
Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR. |
apparentlymart
previously approved these changes
Nov 22, 2024
Contributor
apparentlymart
left a comment
There was a problem hiding this comment.
This approach seems good to me!
cam72cam
previously approved these changes
Nov 25, 2024
Signed-off-by: Ronny Orot <ronny.orot@gmail.com>
3f9637b
cam72cam
approved these changes
Nov 25, 2024
apparentlymart
pushed a commit
that referenced
this pull request
Dec 3, 2024
Signed-off-by: Ronny Orot <ronny.orot@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested by @apparentlymart, the
tofu destroycommand should ignore import blocks. So, this solution skips resolving and expanding import targets when we are running as part of the "preDestroyRefresh" mode.Resolves #1803
Target Release
1.9.0
Checklist
Go checklist