fix: unused config's create_before_destroy on resource change with no refresh

[ollevche]

In this PR I add an additional refresh state write on planning even when refresh=false is used, since this is the place where we synchronize configuration create_before_destroy value with the state itself. As discussed in the issue, we only write to the refreshed state for this specific use case (refresh=false + configuration value present + state value differs).

Note: I didn't alter the logic of create_before_destroy itself, however I suspect there could be a problem for cases when OpenTofu needs to use state's value (inherited) when replacing a resource even if the configuration doesn't force cbd anymore. Not sure if that's a practical problem though.

Also, I removed a few unused params, which I encountered during debugging. This is irrelevant to the PR, however those are pretty small changes.

Resolves #1806

Target Release

1.9.0

Checklist

• I have read the contribution guide.
• I have not used an AI coding assistant to create this PR.
• I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.
• I (and other contributors to this PR) have not looked at the Terraform source code while implementing this PR.

Go checklist

• I have run golangci-lint on my change and receive no errors relevant to my code.
• I have run existing tests to ensure my code doesn't break anything.
• I have added tests for all relevant use cases of my code, and those tests are passing.
• I have only exported functions, variables and structs that should be used from other packages.
• I have added meaningful comments to all exported functions, variables, and structs.

[github-actions]

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

[apparentlymart]

This seems plausible! 👍

Having another weird special case makes me a little nervous, but it's at least relatively self-contained and I don't really have a better idea for how to do this with how the code is currently structured.