Skip to content

add simulated state serialization between tofu test runs#2274

Merged
ollevche merged 3 commits intomainfrom
fix-tofu-test-mod-outputs
Dec 10, 2024
Merged

add simulated state serialization between tofu test runs#2274
ollevche merged 3 commits intomainfrom
fix-tofu-test-mod-outputs

Conversation

@ollevche
Copy link
Copy Markdown
Contributor

@ollevche ollevche commented Dec 10, 2024

Resolves #2260.

This PR adds a simulation of state file write between multiple tofu test runs.

The fix needs to be backported

Target Release

1.9.0

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.
  • I (and other contributors to this PR) have not looked at the Terraform source code while implementing this PR.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

Signed-off-by: ollevche <ollevche@gmail.com>
@ollevche ollevche requested a review from a team as a code owner December 10, 2024 13:13
ghost
ghost previously approved these changes Dec 10, 2024
@opentofu opentofu deleted a comment from github-actions bot Dec 10, 2024
Signed-off-by: ollevche <ollevche@gmail.com>
cam72cam
cam72cam previously approved these changes Dec 10, 2024
Copy link
Copy Markdown
Member

@cam72cam cam72cam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's definitely a weird one, but probably the most stable way to accomplish this for now.

ghost
ghost previously approved these changes Dec 10, 2024
Signed-off-by: ollevche <ollevche@gmail.com>
@ollevche ollevche dismissed stale reviews from ghost and cam72cam via da4cc2b December 10, 2024 14:11
@ollevche ollevche requested review from a user and cam72cam December 10, 2024 14:27
@ollevche ollevche merged commit 5f8eee4 into main Dec 10, 2024
@ollevche ollevche deleted the fix-tofu-test-mod-outputs branch December 10, 2024 14:34
ollevche added a commit that referenced this pull request Dec 10, 2024
Signed-off-by: ollevche <ollevche@gmail.com>
@ollevche ollevche mentioned this pull request Dec 10, 2024
4 tasks
ollevche added a commit that referenced this pull request Dec 10, 2024
Signed-off-by: ollevche <ollevche@gmail.com>
ollevche added a commit that referenced this pull request Dec 10, 2024
Signed-off-by: ollevche <ollevche@gmail.com>
ollevche added a commit that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resources persist between tests when testing nested modules with tofu test

2 participants