Skip to content

Skip reading encryption keys on tofu init with -backend=false flag set#2293

Merged
ollevche merged 6 commits into
opentofu:mainfrom
Zanda256:fix-2217-tofu-init-skip-encrypt-with-backend-false
Dec 20, 2024
Merged

Skip reading encryption keys on tofu init with -backend=false flag set#2293
ollevche merged 6 commits into
opentofu:mainfrom
Zanda256:fix-2217-tofu-init-skip-encrypt-with-backend-false

Conversation

@Zanda256
Copy link
Copy Markdown
Contributor

@Zanda256 Zanda256 commented Dec 13, 2024

With this change, tofu init -backend=false runs successfully without attempting to read encryption keys as suggested by @bt909

Resolves #2217

Target Release

1.10.0

Checklist

  • I have read the contribution guide.
  • I have not used an AI coding assistant to create this PR.
  • I have written all code in this PR myself OR I have marked all code I have not written myself (including modified code, e.g. copied from other places and then modified) with a comment indicating where it came from.
  • I (and other contributors to this PR) have not looked at the Terraform source code while implementing this PR.

Go checklist

  • I have run golangci-lint on my change and receive no errors relevant to my code.
  • I have run existing tests to ensure my code doesn't break anything.
  • I have added tests for all relevant use cases of my code, and those tests are passing.
  • I have only exported functions, variables and structs that should be used from other packages.
  • I have added meaningful comments to all exported functions, variables, and structs.

Website/documentation checklist

  • I have locally started the website as described here and checked my changes.

@Zanda256 Zanda256 requested a review from a team as a code owner December 13, 2024 10:47
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 13, 2024

Reminder for the PR assignee: If this is a user-visible change, please update the changelog as part of the PR.

@Zanda256
Disable encryption when -backend=false is set
89d3660 
Signed-off-by: Sekiranda <sekirandahamza@gmail.com>
@Zanda256
Add test cases for disabled encryption
df611a2 
Signed-off-by: Sekiranda <sekirandahamza@gmail.com>
@Zanda256 Zanda256 force-pushed the fix-2217-tofu-init-skip-encrypt-with-backend-false branch from 2e147c7 to df611a2 Compare December 13, 2024 10:49
@ollevche
Copy link
Copy Markdown
Contributor

ollevche commented Dec 13, 2024 •
edited
Loading

Thanks for the contribution @Zanda256! Could you please add an entry to the changelog file?

@Zanda256
Fix lint error
1de8512 
Signed-off-by: Sekiranda <sekirandahamza@gmail.com>
@Zanda256
Add test cases for disabled encryption
edd9060 
Signed-off-by: Sekiranda <sekirandahamza@gmail.com>
@Zanda256
Add bug fix to change log
5ec59dc 
Signed-off-by: Sekiranda <sekirandahamza@gmail.com>
@ollevche
Copy link
Copy Markdown
Contributor

ollevche commented Dec 16, 2024

Hey @Zanda256 there is one more linting issue left, could you please take a look?

@Zanda256
Fix whitespace lint error
2c1d523 
Signed-off-by: Sekiranda <sekirandahamza@gmail.com>
@Zanda256
Copy link
Copy Markdown
Contributor Author

Zanda256 commented Dec 17, 2024

Hey @Zanda256 there is one more linting issue left, could you please take a look?

Thanks for pointing that out @ollevche , I've fixed it.

@ollevche
Copy link
Copy Markdown
Contributor

ollevche commented Dec 17, 2024

Thanks for the contribution @Zanda256!

@Zanda256
Copy link
Copy Markdown
Contributor Author

Zanda256 commented Dec 17, 2024

Thanks for the contribution @Zanda256!

My pleasure @ollevche .

@ollevche ollevche merged commit 211ec55 into opentofu:main Dec 20, 2024
ollevche pushed a commit that referenced this pull request Dec 20, 2024
@Zanda256 @ollevche
Skip reading encryption keys on tofu init with -backend=false fl…
8d0bf60 
…ag set (#2293)

Signed-off-by: Sekiranda <sekirandahamza@gmail.com>
ollevche pushed a commit that referenced this pull request Dec 20, 2024
@Zanda256 @ollevche
Skip reading encryption keys on tofu init with -backend=false fl…
191e75a 
…ag set (#2293)

Signed-off-by: Sekiranda <sekirandahamza@gmail.com>
Signed-off-by: ollevche <ollevche@gmail.com>
ollevche pushed a commit that referenced this pull request Dec 20, 2024
@Zanda256 @ollevche
Skip reading encryption keys on tofu init with -backend=false fl…
59477d7 
…ag set (#2293)

Signed-off-by: Sekiranda <sekirandahamza@gmail.com>
Signed-off-by: ollevche <ollevche@gmail.com>
ollevche pushed a commit that referenced this pull request Dec 20, 2024
@Zanda256 @ollevche
Skip reading encryption keys on tofu init with -backend=false fl…
eda5c69 
…ag set (#2293)

Signed-off-by: Sekiranda <sekirandahamza@gmail.com>
Signed-off-by: ollevche <ollevche@gmail.com>
ollevche added a commit that referenced this pull request Dec 20, 2024
@ollevche @Zanda256
[BACKPORT v1.9] Skip reading encryption keys on tofu init with `-b…
cd81bfb 
…ackend=false` flag set (#2293) (#2309)

Signed-off-by: Sekiranda <sekirandahamza@gmail.com>
Signed-off-by: ollevche <ollevche@gmail.com>
Co-authored-by: Sekiranda Hamza <55385490+Zanda256@users.noreply.github.com>
@cam72cam cam72cam modified the milestone: 1.10.0 (planning) Jan 8, 2025
@tiberium tiberium mentioned this pull request Sep 5, 2025
Closed
@mburumaxwell mburumaxwell mentioned this pull request May 3, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ollevche ollevche ollevche approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tofu validate should work without key for state encryption (w/ -backend=false)

3 participants

@Zanda256 @ollevche @cam72cam