New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keys flee being selected with accidental drag! (seen on timeline) #1671

Closed
snapai opened this Issue Dec 10, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@snapai
Contributor

snapai commented Dec 10, 2017

Selecting keys in multiple columns, where the second click accidentally includes a drag, causes even the unselected keys to "run away" effectively disappearing from the timeline. It also doesn't do this within an undo/redo wrapper, so the result is data loss that must be reverted.
keyflee

Steps to replicate:

  1. Have multiple columns with concurrent keyframes on multiple frames.
  2. Click one key in a same-frame line of keys.
  3. Hold shift and click another key in the same line, with a drag event at the end of the click (ludicrously easy to do on a 2000+ lpi tablet), or click-and-drag again afterwards.
  4. Watch your keys (even the unselected ones) fly away, never to return!
  5. Notice how undo doesn't bring them back.
@manongjohn

This comment has been minimized.

Show comment
Hide comment
@manongjohn

manongjohn Dec 10, 2017

Collaborator

What happens in Xsheet mode? Curious if this is an old bug or something introduced with timeline or timeline flip.

Will try and reproduce when I get a chance.

Collaborator

manongjohn commented Dec 10, 2017

What happens in Xsheet mode? Curious if this is an old bug or something introduced with timeline or timeline flip.

Will try and reproduce when I get a chance.

@snapai

This comment has been minimized.

Show comment
Hide comment
@snapai

snapai Dec 10, 2017

Contributor

@manongjohn They move in their column, but not in their frame at all. Appears to be specific to timeline view. It does NOT do it in the timeline of the 10-18 build of OTX, so it's at least new since then.

Contributor

snapai commented Dec 10, 2017

@manongjohn They move in their column, but not in their frame at all. Appears to be specific to timeline view. It does NOT do it in the timeline of the 10-18 build of OTX, so it's at least new since then.

@manongjohn

This comment has been minimized.

Show comment
Hide comment
@manongjohn

manongjohn Dec 10, 2017

Collaborator

@snapai Thanks for the follow up. Sounds like it might be due to the timeline flip. I already found and fixed another keyframe movement bug related to timeline flip. Will investigate what you found further.

Collaborator

manongjohn commented Dec 10, 2017

@snapai Thanks for the follow up. Sounds like it might be due to the timeline flip. I already found and fixed another keyframe movement bug related to timeline flip. Will investigate what you found further.

shun-iwasawa added a commit that referenced this issue Jan 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment