[Ubuntu 16.10 amd64] Build error liblzo2, (workaround available, waiting on review)

[ckorn]

The build fails on Ubuntu 16.10 amd64.

[ 74%] Building C object lzodriver/CMakeFiles/lzocompress.dir/lzocompress.c.o
/«PKGBUILDDIR»/thirdparty/lzo/driver/lzocompress.c: In function 'main':
/«PKGBUILDDIR»/thirdparty/lzo/driver/lzocompress.c:51:3: warning: ignoring return value of 'fread', declared with attribute warn_unused_result [-Wunused-result]
   fread(src, 1, src_len, stdin);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 74%] Linking C executable ../bin/lzocompress
/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/6/../../../x86_64-linux-gnu/liblzo2.a(lzo1x_1.o): relocation R_X86_64_PC32 against symbol `memset@@GLIBC_2.2.5' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: final link failed: Bad value

This the entire build log:
http://zulu309.server4you.de/build/logs/opentoonz_1.1.1-1~getdeb2~yakkety-amd64-20161017-0303

//Just for my reference: https://paste.ubuntuusers.de/423188/

[ideasman42]

Could you enable -fPIC as suggested?

[ideasman42]

No reply in over a week. closing.

[caryoscelus]

I have a similar issue on debian sid.

Could you enable -fPIC as suggested?

Enable where? Error line suggests that fPIC should be enabled on system library if i read that correctly. It doesn't make sense to rebuild system lib. Compile guide mentions only tiff building. Do we actually need build all third-party packages?

/usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/6/../../../x86_64-linux-gnu/liblzo2.a(lzo_init.o): relocation R_X86_64_PC32 against symbol `__stack_chk_fail@@GLIBC_2.4' can not be used when making a shared object; recompile with -fPIC

[ideasman42]

Try add -fPIC to CMAKE_C_FLAGS and CMAKE_CXX_FLAGS in CMakeCache.txt.

[caryoscelus]

Doesn't work. Tried adding it both manually and through cmake -DCMAKE_C_FLAGS="-fPIC" -DCMAKE_CXX_FLAGS="-fPIC" ../sources/

[ideasman42]

Seems this is an issue with the options used in building the systems liblzo.a, see related issue with xen: https://lists.xen.org/archives/html/xen-devel/2014-07/msg03859.html

You can workaround this by editing your CMakeCache.txt, replacing liblzo.a with liblzo.so.

As a fix/workaround, CMake can prefer the .so file, so developers on Linux wont need to make manual adjustments, see PR: #899

[caryoscelus]

This seems to fix it, thanks.

[ideasman42]

Reported upstream https://bugs.launchpad.net/ubuntu/+source/lzo2/+bug/1638535

[ckorn]

The workaround works fine. Thanks.

When upstream has to fix it this bug can be closed.

[ideasman42]

@ckorn Ideally building should succeed without having to perform manual workarounds (for common Linux distros at least) - rather leave this open until building works out of the box.