New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyPaint brushes for OpenToonz raster levels #1124

Merged
merged 36 commits into from Aug 4, 2017

Conversation

Projects
None yet
8 participants
@blackwarthog
Collaborator

blackwarthog commented Mar 27, 2017

This it implementation of this feature request #417

You can see its demonstration in the video below:
MyPaint brushes in OpenToonz
https://www.youtube.com/watch?v=2_lD654uAZ4

You can test this feature using these binary builds:
https://gumroad.com/l/opentoonz

@blackwarthog

This comment has been minimized.

Show comment
Hide comment
@blackwarthog

blackwarthog Mar 27, 2017

Collaborator

This feature tested on Linux and Windows (MinGW #1092)

Collaborator

blackwarthog commented Mar 27, 2017

This feature tested on Linux and Windows (MinGW #1092)

@konero konero referenced this pull request Mar 30, 2017

Merged

Minimalist Theme #1112

4 of 4 tasks complete
@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Apr 21, 2017

I think I'm in love.

ghost commented Apr 21, 2017

I think I'm in love.

@Number0001

This comment has been minimized.

Show comment
Hide comment

Number0001 commented Apr 22, 2017

@shun-iwasawa @konero @ksk575 @Nico-Duduf @mitchfoo @mqudsi @photopea @abuhenasobuj
I would like to hear your opinion.

@abuhenasobuj

This comment has been minimized.

Show comment
Hide comment
@abuhenasobuj

abuhenasobuj Apr 23, 2017

@Number0001, How you gotten my username?

abuhenasobuj commented Apr 23, 2017

@Number0001, How you gotten my username?

@Number0001

This comment has been minimized.

Show comment
Hide comment
@Number0001

Number0001 Apr 23, 2017

Common acquaintances. @abuhenasobuj

Number0001 commented Apr 23, 2017

Common acquaintances. @abuhenasobuj

@blurymind

This comment has been minimized.

Show comment
Hide comment
@blurymind

blurymind Apr 23, 2017

blurymind commented Apr 23, 2017

@mqudsi

This comment has been minimized.

Show comment
Hide comment
@mqudsi

mqudsi Apr 23, 2017

Please don't spam random mentions.

mqudsi commented Apr 23, 2017

Please don't spam random mentions.

@turtletooth

This comment has been minimized.

Show comment
Hide comment
@turtletooth

turtletooth Apr 25, 2017

Collaborator

I just used the newest version from the Morevna site- and holy cow. It works great, nice and fast and very fluid.

Collaborator

turtletooth commented Apr 25, 2017

I just used the newest version from the Morevna site- and holy cow. It works great, nice and fast and very fluid.

@turtletooth

This comment has been minimized.

Show comment
Hide comment
@turtletooth

turtletooth May 24, 2017

Collaborator

@blackwarthog Once the last mingw PR is merged, should I be able to build this and test this with MSVC? Are there any additional steps I would need to test this?

Collaborator

turtletooth commented May 24, 2017

@blackwarthog Once the last mingw PR is merged, should I be able to build this and test this with MSVC? Are there any additional steps I would need to test this?

@blackwarthog

This comment has been minimized.

Show comment
Hide comment
@blackwarthog

blackwarthog May 24, 2017

Collaborator

@turtletooth no, when mingw PR will merged we also should to implement MSVC and OSX support. For now i'm working on OSX, and after that on MSVC.

Collaborator

blackwarthog commented May 24, 2017

@turtletooth no, when mingw PR will merged we also should to implement MSVC and OSX support. For now i'm working on OSX, and after that on MSVC.

@turtletooth

This comment has been minimized.

Show comment
Hide comment
@turtletooth

turtletooth May 24, 2017

Collaborator

@blackwarthog Sounds good.

Collaborator

turtletooth commented May 24, 2017

@blackwarthog Sounds good.

blackwarthog added some commits Feb 14, 2017

@blackwarthog

This comment has been minimized.

Show comment
Hide comment
@blackwarthog

blackwarthog Jul 25, 2017

Collaborator

I've added build support for OSX and MSVC.
For OSX you need to install libmypaint via brew.
For MSVC copy DLLs from thirdparty/libmypaint/dist/{32|64}/*.dll into Release directory after compilation.

Collaborator

blackwarthog commented Jul 25, 2017

I've added build support for OSX and MSVC.
For OSX you need to install libmypaint via brew.
For MSVC copy DLLs from thirdparty/libmypaint/dist/{32|64}/*.dll into Release directory after compilation.

@turtletooth

This comment has been minimized.

Show comment
Hide comment
@turtletooth

turtletooth Jul 26, 2017

Collaborator

@blackwarthog Thanks so much for doing this. It works great with MSVC and is a HUGE improvement to the software.

Collaborator

turtletooth commented Jul 26, 2017

@blackwarthog Thanks so much for doing this. It works great with MSVC and is a HUGE improvement to the software.

@shun-iwasawa shun-iwasawa referenced this pull request Jul 31, 2017

Closed

New Contributor? #1357

@shun-iwasawa

This comment has been minimized.

Show comment
Hide comment
@shun-iwasawa

shun-iwasawa Jul 31, 2017

Member

It seems that brew install libmypaint is needed in travis-install.sh in order to run the travis CI.
travis-install.sh for linux should be updated as well.

Member

shun-iwasawa commented Jul 31, 2017

It seems that brew install libmypaint is needed in travis-install.sh in order to run the travis CI.
travis-install.sh for linux should be updated as well.

@blurymind

This comment has been minimized.

Show comment
Hide comment
@blurymind

blurymind Jul 31, 2017

I tested it on one of @turtletooth 's preview builds. Works like a charm!

Is it possible to create new mypaint brushes within Open toonz, or do we still require mypaint to do that?

It will be kind of nice if it is possible to save a brush as a new preset, not sure how it's thumbnail would be created, as OT has no brush thumbnail editor like Krita and mypaint :)

How do we import new brushes? Copy them to a folder?

blurymind commented Jul 31, 2017

I tested it on one of @turtletooth 's preview builds. Works like a charm!

Is it possible to create new mypaint brushes within Open toonz, or do we still require mypaint to do that?

It will be kind of nice if it is possible to save a brush as a new preset, not sure how it's thumbnail would be created, as OT has no brush thumbnail editor like Krita and mypaint :)

How do we import new brushes? Copy them to a folder?

@shun-iwasawa

This comment has been minimized.

Show comment
Hide comment
@shun-iwasawa

shun-iwasawa Aug 2, 2017

Member

Jenkins

Member

shun-iwasawa commented Aug 2, 2017

Jenkins

@morevnaproject

This comment has been minimized.

Show comment
Hide comment
@morevnaproject

morevnaproject Aug 2, 2017

Contributor

@blurymind

Is it possible to create new mypaint brushes within Open toonz, or do we still require mypaint to do that?

At the moment you can configure new brushes using styles. Please see the "Improved styles management" section here - https://morevnaproject.org/2017/04/09/open-toonz-builds-updated/

Contributor

morevnaproject commented Aug 2, 2017

@blurymind

Is it possible to create new mypaint brushes within Open toonz, or do we still require mypaint to do that?

At the moment you can configure new brushes using styles. Please see the "Improved styles management" section here - https://morevnaproject.org/2017/04/09/open-toonz-builds-updated/

@blurymind

This comment has been minimized.

Show comment
Hide comment
@blurymind

blurymind Aug 2, 2017

blurymind commented Aug 2, 2017

@morevnaproject

This comment has been minimized.

Show comment
Hide comment
@morevnaproject

morevnaproject Aug 2, 2017

Contributor

But can you save a style as a new style and reset to default values?

Please read the link I referenced above. It explains everything. ^__^

Contributor

morevnaproject commented Aug 2, 2017

But can you save a style as a new style and reset to default values?

Please read the link I referenced above. It explains everything. ^__^

@shun-iwasawa

This comment has been minimized.

Show comment
Hide comment
@shun-iwasawa

shun-iwasawa Aug 3, 2017

Member

@blackwarthog
Confirmed that it works fine on both Windows and OSX. Thank you for the great contribution on this!

My only and big concern for this PR is about licenses of DLLs you are including in thirdparty/libmypaint/dist/{32|64}/. Could you please provide a list of links to the licenses of them?
In short, I just would like to confirm that they are not under GPL licenses, which will conflict with new-BSD.
Thanks!

Member

shun-iwasawa commented Aug 3, 2017

@blackwarthog
Confirmed that it works fine on both Windows and OSX. Thank you for the great contribution on this!

My only and big concern for this PR is about licenses of DLLs you are including in thirdparty/libmypaint/dist/{32|64}/. Could you please provide a list of links to the licenses of them?
In short, I just would like to confirm that they are not under GPL licenses, which will conflict with new-BSD.
Thanks!

@blackwarthog

This comment has been minimized.

Show comment
Hide comment
@blackwarthog

blackwarthog Aug 3, 2017

Collaborator

Thank you for your notify. I've found that libgettext licensed by GPL, but it was easy to eliminate this dependency and i did it.

For all other libraries I've added license files. Thank you again.

Collaborator

blackwarthog commented Aug 3, 2017

Thank you for your notify. I've found that libgettext licensed by GPL, but it was easy to eliminate this dependency and i did it.

For all other libraries I've added license files. Thank you again.

@shun-iwasawa

This comment has been minimized.

Show comment
Hide comment
@shun-iwasawa

shun-iwasawa Aug 4, 2017

Member

@blackwarthog
It's so fun to paint with this. Thank you very much for the great work done so far!
lgtm

Member

shun-iwasawa commented Aug 4, 2017

@blackwarthog
It's so fun to paint with this. Thank you very much for the great work done so far!
lgtm

@shun-iwasawa shun-iwasawa merged commit bf1d82a into opentoonz:master Aug 4, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@shun-iwasawa

This comment has been minimized.

Show comment
Hide comment
@shun-iwasawa

shun-iwasawa Aug 4, 2017

Member

@blackwarthog
Again, thank you for your huge contribution.
We'll be happy if you could improve OpenToonz continuously and would like to assign you as a collaborator.

Member

shun-iwasawa commented Aug 4, 2017

@blackwarthog
Again, thank you for your huge contribution.
We'll be happy if you could improve OpenToonz continuously and would like to assign you as a collaborator.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 4, 2017

I have built this on linux but in the mypaint brushes tab I only find No Brush.
Are there any files that I should place somewhere in order to get the brushes?

ghost commented Aug 4, 2017

I have built this on linux but in the mypaint brushes tab I only find No Brush.
Are there any files that I should place somewhere in order to get the brushes?

@blackwarthog

This comment has been minimized.

Show comment
Hide comment
@blackwarthog

blackwarthog Aug 4, 2017

Collaborator

Much thanks :)

Collaborator

blackwarthog commented Aug 4, 2017

Much thanks :)

@blackwarthog

This comment has been minimized.

Show comment
Hide comment
@blackwarthog

blackwarthog Aug 4, 2017

Collaborator

@lordadamson you need to update your "stuff" directory. Just copy "./stuff/library/mypaint brushes" to "~/.config/OpenToonz/stuff/library/"

Also check variables in ~/.config/OpenToonz/SystemVars.ini:
- TOONZLIBRARY should be like "/home/USERNAME/.config/OpenToonz/stuff/library";
- TOONZFXPRESETS should be "/home/USERNAME/.config/OpenToonz/stuff/fxs".

Collaborator

blackwarthog commented Aug 4, 2017

@lordadamson you need to update your "stuff" directory. Just copy "./stuff/library/mypaint brushes" to "~/.config/OpenToonz/stuff/library/"

Also check variables in ~/.config/OpenToonz/SystemVars.ini:
- TOONZLIBRARY should be like "/home/USERNAME/.config/OpenToonz/stuff/library";
- TOONZFXPRESETS should be "/home/USERNAME/.config/OpenToonz/stuff/fxs".

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 4, 2017

yaaay it worked :D
brb I'll be updating the build instructions for linux accordingly :D

ghost commented Aug 4, 2017

yaaay it worked :D
brb I'll be updating the build instructions for linux accordingly :D

@blackwarthog blackwarthog deleted the blackwarthog:brush branch Aug 4, 2017

@blackwarthog

This comment has been minimized.

Show comment
Hide comment
@blackwarthog

blackwarthog Aug 4, 2017

Collaborator

It's actual only when you have previous version of opentoonz installed. Build on the clean system works fine.

Collaborator

blackwarthog commented Aug 4, 2017

It's actual only when you have previous version of opentoonz installed. Build on the clean system works fine.

@morevnaproject

This comment has been minimized.

Show comment
Hide comment
@morevnaproject

morevnaproject Aug 4, 2017

Contributor

Actually this mess with stuff directory on Linux/OSX needs some rework. Default stuff directory should be a part of OpenToonz data files and overridden by data in user home directory (if any). Of course this is a topic for separate discussion. ^__^

Contributor

morevnaproject commented Aug 4, 2017

Actually this mess with stuff directory on Linux/OSX needs some rework. Default stuff directory should be a part of OpenToonz data files and overridden by data in user home directory (if any). Of course this is a topic for separate discussion. ^__^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment