Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MyPaint brushes for OpenToonz raster levels #1124

Merged
merged 36 commits into from Aug 4, 2017

Conversation

@blackwarthog
Copy link
Collaborator

blackwarthog commented Mar 27, 2017

This it implementation of this feature request #417

You can see its demonstration in the video below:
MyPaint brushes in OpenToonz
https://www.youtube.com/watch?v=2_lD654uAZ4

You can test this feature using these binary builds:
https://gumroad.com/l/opentoonz

@blackwarthog
Copy link
Collaborator Author

blackwarthog commented Mar 27, 2017

This feature tested on Linux and Windows (MinGW #1092)

@blackwarthog blackwarthog force-pushed the blackwarthog:brush branch 2 times, most recently from c45ce46 to 9c717b1 Mar 29, 2017
@konero konero mentioned this pull request Mar 30, 2017
4 of 4 tasks complete
@blackwarthog blackwarthog force-pushed the blackwarthog:brush branch from 0fd265a to 452e708 Apr 15, 2017
@ghost
Copy link

ghost commented Apr 21, 2017

I think I'm in love.

@Number0001
Copy link

Number0001 commented Apr 22, 2017

@shun-iwasawa @konero @ksk575 @Nico-Duduf @mitchfoo @mqudsi @photopea @abuhenasobuj
I would like to hear your opinion.

@abuhenasobuj
Copy link

abuhenasobuj commented Apr 23, 2017

@Number0001, How you gotten my username?

@Number0001
Copy link

Number0001 commented Apr 23, 2017

Common acquaintances. @abuhenasobuj

@blurymind
Copy link

blurymind commented Apr 23, 2017

@mqudsi
Copy link

mqudsi commented Apr 23, 2017

Please don't spam random mentions.

@turtletooth
Copy link
Collaborator

turtletooth commented Apr 25, 2017

I just used the newest version from the Morevna site- and holy cow. It works great, nice and fast and very fluid.

@blackwarthog blackwarthog force-pushed the blackwarthog:brush branch from 452e708 to 22b2abb May 22, 2017
@turtletooth
Copy link
Collaborator

turtletooth commented May 24, 2017

@blackwarthog Once the last mingw PR is merged, should I be able to build this and test this with MSVC? Are there any additional steps I would need to test this?

@blackwarthog
Copy link
Collaborator Author

blackwarthog commented May 24, 2017

@turtletooth no, when mingw PR will merged we also should to implement MSVC and OSX support. For now i'm working on OSX, and after that on MSVC.

@turtletooth
Copy link
Collaborator

turtletooth commented May 24, 2017

@blackwarthog Sounds good.

@blackwarthog blackwarthog force-pushed the blackwarthog:brush branch from 22b2abb to c9227f7 May 30, 2017
@blackwarthog blackwarthog force-pushed the blackwarthog:brush branch from c5af389 to 9684923 Jun 15, 2017
@blackwarthog
Copy link
Collaborator Author

blackwarthog commented Jul 25, 2017

I've added build support for OSX and MSVC.
For OSX you need to install libmypaint via brew.
For MSVC copy DLLs from thirdparty/libmypaint/dist/{32|64}/*.dll into Release directory after compilation.

@blackwarthog blackwarthog force-pushed the blackwarthog:brush branch from c5bf40f to 600b47d Jul 25, 2017
@turtletooth
Copy link
Collaborator

turtletooth commented Jul 26, 2017

@blackwarthog Thanks so much for doing this. It works great with MSVC and is a HUGE improvement to the software.

@shun-iwasawa shun-iwasawa mentioned this pull request Jul 31, 2017
@shun-iwasawa
Copy link
Member

shun-iwasawa commented Jul 31, 2017

It seems that brew install libmypaint is needed in travis-install.sh in order to run the travis CI.
travis-install.sh for linux should be updated as well.

@blurymind
Copy link

blurymind commented Jul 31, 2017

I tested it on one of @turtletooth 's preview builds. Works like a charm!

Is it possible to create new mypaint brushes within Open toonz, or do we still require mypaint to do that?

It will be kind of nice if it is possible to save a brush as a new preset, not sure how it's thumbnail would be created, as OT has no brush thumbnail editor like Krita and mypaint :)

How do we import new brushes? Copy them to a folder?

@shun-iwasawa
Copy link
Member

shun-iwasawa commented Aug 2, 2017

Jenkins

@morevnaproject
Copy link
Contributor

morevnaproject commented Aug 2, 2017

@blurymind

Is it possible to create new mypaint brushes within Open toonz, or do we still require mypaint to do that?

At the moment you can configure new brushes using styles. Please see the "Improved styles management" section here - https://morevnaproject.org/2017/04/09/open-toonz-builds-updated/

@blurymind
Copy link

blurymind commented Aug 2, 2017

@morevnaproject
Copy link
Contributor

morevnaproject commented Aug 2, 2017

But can you save a style as a new style and reset to default values?

Please read the link I referenced above. It explains everything. ^__^

@shun-iwasawa
Copy link
Member

shun-iwasawa commented Aug 3, 2017

@blackwarthog
Confirmed that it works fine on both Windows and OSX. Thank you for the great contribution on this!

My only and big concern for this PR is about licenses of DLLs you are including in thirdparty/libmypaint/dist/{32|64}/. Could you please provide a list of links to the licenses of them?
In short, I just would like to confirm that they are not under GPL licenses, which will conflict with new-BSD.
Thanks!

@blackwarthog blackwarthog force-pushed the blackwarthog:brush branch from 600b47d to 6a26def Aug 3, 2017
@blackwarthog
Copy link
Collaborator Author

blackwarthog commented Aug 3, 2017

Thank you for your notify. I've found that libgettext licensed by GPL, but it was easy to eliminate this dependency and i did it.

For all other libraries I've added license files. Thank you again.

@shun-iwasawa
Copy link
Member

shun-iwasawa commented Aug 4, 2017

@blackwarthog
It's so fun to paint with this. Thank you very much for the great work done so far!
lgtm

@shun-iwasawa shun-iwasawa merged commit bf1d82a into opentoonz:master Aug 4, 2017
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@shun-iwasawa
Copy link
Member

shun-iwasawa commented Aug 4, 2017

@blackwarthog
Again, thank you for your huge contribution.
We'll be happy if you could improve OpenToonz continuously and would like to assign you as a collaborator.

@ghost
Copy link

ghost commented Aug 4, 2017

I have built this on linux but in the mypaint brushes tab I only find No Brush.
Are there any files that I should place somewhere in order to get the brushes?

@blackwarthog
Copy link
Collaborator Author

blackwarthog commented Aug 4, 2017

Much thanks :)

@blackwarthog
Copy link
Collaborator Author

blackwarthog commented Aug 4, 2017

@lordadamson you need to update your "stuff" directory. Just copy "./stuff/library/mypaint brushes" to "~/.config/OpenToonz/stuff/library/"

Also check variables in ~/.config/OpenToonz/SystemVars.ini:
- TOONZLIBRARY should be like "/home/USERNAME/.config/OpenToonz/stuff/library";
- TOONZFXPRESETS should be "/home/USERNAME/.config/OpenToonz/stuff/fxs".

@ghost
Copy link

ghost commented Aug 4, 2017

yaaay it worked :D
brb I'll be updating the build instructions for linux accordingly :D

@blackwarthog blackwarthog deleted the blackwarthog:brush branch Aug 4, 2017
@blackwarthog
Copy link
Collaborator Author

blackwarthog commented Aug 4, 2017

It's actual only when you have previous version of opentoonz installed. Build on the clean system works fine.

@morevnaproject
Copy link
Contributor

morevnaproject commented Aug 4, 2017

Actually this mess with stuff directory on Linux/OSX needs some rework. Default stuff directory should be a part of OpenToonz data files and overridden by data in user home directory (if any). Of course this is a topic for separate discussion. ^__^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.