Skip to content

MyPaint brushes for OpenToonz raster levels - #1124

Merged
shun-iwasawa merged 36 commits into
opentoonz:masterfrom
blackwarthog:brush
Aug 4, 2017
Merged

MyPaint brushes for OpenToonz raster levels#1124
shun-iwasawa merged 36 commits into
opentoonz:masterfrom
blackwarthog:brush

Conversation

@blackwarthog

Copy link
Copy Markdown
Collaborator

This it implementation of this feature request #417

You can see its demonstration in the video below:
MyPaint brushes in OpenToonz
https://www.youtube.com/watch?v=2_lD654uAZ4

You can test this feature using these binary builds:
https://gumroad.com/l/opentoonz

@blackwarthog

Copy link
Copy Markdown
Collaborator Author

This feature tested on Linux and Windows (MinGW #1092)

@ghost

ghost commented Apr 21, 2017

Copy link
Copy Markdown

I think I'm in love.

@Number0001

Copy link
Copy Markdown

@shun-iwasawa @konero @ksk575 @Nico-Duduf @mitchfoo @mqudsi @photopea @abuhenasobuj
I would like to hear your opinion.

@abuhenasobuj

Copy link
Copy Markdown

@Number0001, How you gotten my username?

@Number0001

Copy link
Copy Markdown

Common acquaintances. @abuhenasobuj

@blurymind

blurymind commented Apr 23, 2017 via email

Copy link
Copy Markdown

@mqudsi

mqudsi commented Apr 23, 2017

Copy link
Copy Markdown

Please don't spam random mentions.

@ghost

ghost commented Apr 25, 2017

Copy link
Copy Markdown

I just used the newest version from the Morevna site- and holy cow. It works great, nice and fast and very fluid.

@ghost

ghost commented May 24, 2017

Copy link
Copy Markdown

@blackwarthog Once the last mingw PR is merged, should I be able to build this and test this with MSVC? Are there any additional steps I would need to test this?

@blackwarthog

Copy link
Copy Markdown
Collaborator Author

@turtleTooth no, when mingw PR will merged we also should to implement MSVC and OSX support. For now i'm working on OSX, and after that on MSVC.

@ghost

ghost commented May 24, 2017

Copy link
Copy Markdown

@blackwarthog Sounds good.

@blackwarthog

Copy link
Copy Markdown
Collaborator Author

I've added build support for OSX and MSVC.
For OSX you need to install libmypaint via brew.
For MSVC copy DLLs from thirdparty/libmypaint/dist/{32|64}/*.dll into Release directory after compilation.

@ghost

ghost commented Jul 26, 2017

Copy link
Copy Markdown

@blackwarthog Thanks so much for doing this. It works great with MSVC and is a HUGE improvement to the software.

@shun-iwasawa shun-iwasawa mentioned this pull request Jul 31, 2017
@shun-iwasawa

Copy link
Copy Markdown
Member

It seems that brew install libmypaint is needed in travis-install.sh in order to run the travis CI.
travis-install.sh for linux should be updated as well.

@blurymind

blurymind commented Jul 31, 2017

Copy link
Copy Markdown

I tested it on one of @turtleTooth 's preview builds. Works like a charm!

Is it possible to create new mypaint brushes within Open toonz, or do we still require mypaint to do that?

It will be kind of nice if it is possible to save a brush as a new preset, not sure how it's thumbnail would be created, as OT has no brush thumbnail editor like Krita and mypaint :)

How do we import new brushes? Copy them to a folder?

@shun-iwasawa

Copy link
Copy Markdown
Member

Jenkins

@morevnaproject

Copy link
Copy Markdown
Contributor

@blurymind

Is it possible to create new mypaint brushes within Open toonz, or do we still require mypaint to do that?

At the moment you can configure new brushes using styles. Please see the "Improved styles management" section here - https://morevnaproject.org/2017/04/09/open-toonz-builds-updated/

@blurymind

blurymind commented Aug 2, 2017 via email

Copy link
Copy Markdown

@morevnaproject

Copy link
Copy Markdown
Contributor

But can you save a style as a new style and reset to default values?

Please read the link I referenced above. It explains everything. ^__^

@shun-iwasawa

shun-iwasawa commented Aug 3, 2017

Copy link
Copy Markdown
Member

@blackwarthog
Confirmed that it works fine on both Windows and OSX. Thank you for the great contribution on this!

My only and big concern for this PR is about licenses of DLLs you are including in thirdparty/libmypaint/dist/{32|64}/. Could you please provide a list of links to the licenses of them?
In short, I just would like to confirm that they are not under GPL licenses, which will conflict with new-BSD.
Thanks!

@blackwarthog

Copy link
Copy Markdown
Collaborator Author

Thank you for your notify. I've found that libgettext licensed by GPL, but it was easy to eliminate this dependency and i did it.

For all other libraries I've added license files. Thank you again.

@shun-iwasawa

Copy link
Copy Markdown
Member

@blackwarthog
It's so fun to paint with this. Thank you very much for the great work done so far!
lgtm

@shun-iwasawa
shun-iwasawa merged commit bf1d82a into opentoonz:master Aug 4, 2017
@shun-iwasawa

Copy link
Copy Markdown
Member

@blackwarthog
Again, thank you for your huge contribution.
We'll be happy if you could improve OpenToonz continuously and would like to assign you as a collaborator.

@ghost

ghost commented Aug 4, 2017

Copy link
Copy Markdown

I have built this on linux but in the mypaint brushes tab I only find No Brush.
Are there any files that I should place somewhere in order to get the brushes?

@blackwarthog

Copy link
Copy Markdown
Collaborator Author

Much thanks :)

@blackwarthog

Copy link
Copy Markdown
Collaborator Author

@lordadamson you need to update your "stuff" directory. Just copy "./stuff/library/mypaint brushes" to "~/.config/OpenToonz/stuff/library/"

Also check variables in ~/.config/OpenToonz/SystemVars.ini:
- TOONZLIBRARY should be like "/home/USERNAME/.config/OpenToonz/stuff/library";
- TOONZFXPRESETS should be "/home/USERNAME/.config/OpenToonz/stuff/fxs".

@ghost

ghost commented Aug 4, 2017

Copy link
Copy Markdown

yaaay it worked :D
brb I'll be updating the build instructions for linux accordingly :D

@blackwarthog

Copy link
Copy Markdown
Collaborator Author

It's actual only when you have previous version of opentoonz installed. Build on the clean system works fine.

@morevnaproject

Copy link
Copy Markdown
Contributor

Actually this mess with stuff directory on Linux/OSX needs some rework. Default stuff directory should be a part of OpenToonz data files and overridden by data in user home directory (if any). Of course this is a topic for separate discussion. ^__^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants