Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script for updating/adding translation TS files #1709

Merged

Conversation

morevnaproject
Copy link
Contributor

An utility script for updating/adding translation TS files.

Usage: update.sh LANGUAGE

With this script it is easy to create new language. I.e. just execute "update.sh portuguese" to add Portuguese language.

…nguage.

Usage: update.sh LANGUAGE

With this script it is easy to create new language. I.e. just execute "update.sh portuguese" to add Portuguese language.
@morevnaproject
Copy link
Contributor Author

Hello! Any chances to get this merged? ^__^

This is useful, so anyone know how to update ts files, as done in #1610.

@shun-iwasawa
Copy link
Member

@morevnaproject
Now I understand it will be useful for translators who would like to update existing TS files without cumbersome steps. For adding a new language (like Portuguese) it may be needed to edit CMakeLists.txt as well for future maintenance.

I'll review this before releasing the next version. Thanks!

BASE_DIR=$(cd `dirname "$0"`; pwd)
TOONZLANG=$1

[ ! -d "${BASE_DIR}/${TOONZLANG}" ] || mkdir -p "${BASE_DIR}/${TOONZLANG}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be
[ ! -d "${BASE_DIR}/${TOONZLANG}" ] && mkdir -p "${BASE_DIR}/${TOONZLANG}"
or
[ -d "${BASE_DIR}/${TOONZLANG}" ] || mkdir -p "${BASE_DIR}/${TOONZLANG}"
?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed now. Thank you!

@shun-iwasawa
Copy link
Member

It works fine. Thank you @morevnaproject ! LGTM

@shun-iwasawa shun-iwasawa merged commit 085f88d into opentoonz:master May 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants