New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to build in Linux (now in master) #51

Closed
wants to merge 146 commits into
base: master
from

Conversation

Projects
None yet
@ideasman42
Collaborator

ideasman42 commented Mar 26, 2016

Edits needed for compiling on linux.

  • Audio using SDL.
  • Quicktime is disabled (using proxy only).
Edits to build in Linux
Doesn't link yet!

- Atomic is just using regular operations (not so hard to resolve).
- Audio stubbed out (code is using SGI-only libs)
- Quicktime is disabled (using proxy only).
@justinclift

This comment has been minimized.

Show comment
Hide comment
@justinclift

justinclift Mar 26, 2016

Heh Heh Heh

if(UNIX AND NOT APPLE)
set(LINUX TRUE)
endif()

Assuming Linux if it's not Apple will probably upset the BSD crowd. Just saying. 😁

justinclift commented Mar 26, 2016

Heh Heh Heh

if(UNIX AND NOT APPLE)
set(LINUX TRUE)
endif()

Assuming Linux if it's not Apple will probably upset the BSD crowd. Just saying. 😁

@linkmauve

This comment has been minimized.

Show comment
Hide comment
@linkmauve

linkmauve Mar 26, 2016

First pass on this PR, it’s pretty nice, I just added some nitpicks here and there (mostly style and portability).

I haven’t tested it though.

Thank you!

linkmauve commented Mar 26, 2016

First pass on this PR, it’s pretty nice, I just added some nitpicks here and there (mostly style and portability).

I haven’t tested it though.

Thank you!

@ideasman42

This comment has been minimized.

Show comment
Hide comment
@ideasman42

ideasman42 Mar 27, 2016

Collaborator

Thanks for the feedback, realize this PR was too rough for direct inclusion, but thought it might be good to get some feedback on initial changes.

Probably best this be split up for easier review...

I've made separate PR's for the simple/non-controversial changes (upper/lowercase errors, obvious portability issues), so review should be quick.

#61, #62, #63, #64

If these are accepted, its easier to check on more involved changes, so this PR can be updated and not have as many noisy edits.

Collaborator

ideasman42 commented Mar 27, 2016

Thanks for the feedback, realize this PR was too rough for direct inclusion, but thought it might be good to get some feedback on initial changes.

Probably best this be split up for easier review...

I've made separate PR's for the simple/non-controversial changes (upper/lowercase errors, obvious portability issues), so review should be quick.

#61, #62, #63, #64

If these are accepted, its easier to check on more involved changes, so this PR can be updated and not have as many noisy edits.

janisozaur added a commit to janisozaur/opentoonz that referenced this pull request Jun 23, 2016

kogaki added a commit that referenced this pull request Jun 23, 2016

Linux support for tfont (Qt), from pr #51 (#466)
Credit goes to François Revol for this work.

janisozaur added a commit to janisozaur/opentoonz that referenced this pull request Jun 23, 2016

Linux support for tsound (SDL2), from pr opentoonz#51
Credit goes to François Revol for this work.

janisozaur added a commit to janisozaur/opentoonz that referenced this pull request Jun 23, 2016

janisozaur added a commit to janisozaur/opentoonz that referenced this pull request Jun 23, 2016

shun-iwasawa added a commit that referenced this pull request Jun 29, 2016

Merge pull request #467 from ideasman42/linux-tsound-pr
Linux support for tsound (SDL2), from pr #51
@ideasman42

This comment has been minimized.

Show comment
Hide comment
@ideasman42

ideasman42 Jun 30, 2016

Collaborator

Changes to build on Linux have now been merged into master,
Big thanks to everyone who tested and submitted fixes.

Closing.

Collaborator

ideasman42 commented Jun 30, 2016

Changes to build on Linux have now been merged into master,
Big thanks to everyone who tested and submitted fixes.

Closing.

@ideasman42 ideasman42 closed this Jun 30, 2016

@metellius

This comment has been minimized.

Show comment
Hide comment
@metellius

metellius Jun 30, 2016

Great work, thank you!

metellius commented Jun 30, 2016

Great work, thank you!

@kogaki

This comment has been minimized.

Show comment
Hide comment
@kogaki

kogaki Jun 30, 2016

Member

Available on Linux is the biggest advance from original Toonz. Thank you for your great contribution. And thanks again for every contributors who have tried this topic for these three months.

Member

kogaki commented Jun 30, 2016

Available on Linux is the biggest advance from original Toonz. Thank you for your great contribution. And thanks again for every contributors who have tried this topic for these three months.

@ideasman42 ideasman42 changed the title from Edits to build in Linux to Edits to build in Linux (now in master) Jul 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment